Skip to content

Fix not all config in docker secret - #1446

Merged
a60814billy merged 1 commit into
developfrom
fix/docker-secret-not-complete
Mar 6, 2020
Merged

Fix not all config in docker secret#1446
a60814billy merged 1 commit into
developfrom
fix/docker-secret-not-complete

Conversation

@a60814billy

@a60814billy a60814billy commented Mar 6, 2020

Copy link
Copy Markdown
Member

Add some missing config in docker secret.

Signed-off-by: BoHong Li <raccoon@hackmd.io>
@a60814billy
a60814billy requested a review from jackycute March 6, 2020 12:52
@Yukaii
Yukaii temporarily deployed to codimd-fix-docker-secre-feudvf March 6, 2020 12:52 Inactive

@jackycute jackycute left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a60814billy

@a60814billy
a60814billy merged commit 42ae89c into develop Mar 6, 2020
@a60814billy
a60814billy deleted the fix/docker-secret-not-complete branch March 6, 2020 13:01
@Yukaii Yukaii added this to the 2.0.1 milestone Apr 9, 2020
edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Sep 21, 2021
This commit adds a `useUnless` helper method which can be used as a middleware for express.
It receives an express-middleware and an array of paths.
When a request matches one of the given paths, this middleware does nothing.
Otherwise the given middleware is called.

For the express-session middleware this helper middleware is used to avoid session creation on purely status routes.
See hackmdio#1446

Signed-off-by: Erik Michelson <github@erik.michelson.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants