Skip to content

removed jquery-ui/* requirements from AMD packing - #1079

Merged
adumesny merged 2 commits into
gridstack:developfrom
adumesny:develop
Nov 28, 2019
Merged

removed jquery-ui/* requirements from AMD packing#1079
adumesny merged 2 commits into
gridstack:developfrom
adumesny:develop

Conversation

@adumesny

Copy link
Copy Markdown
Member

Description

  • now that we have our own subset of JQUI (1/5th the size) as part of all.js (or separate include)
    I had to remove all jquery-ui/* AMD requirements from
    gridstack.jQueryUI.js or I wasn't able to compile my apps
  • now generate jquery-ui.min.js from src (hence demos updates)

will spin new NPM images next as I need these for my Angular apps.

Checklist

  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* now that we have our own subset of JQUI (1/5th the size) as part of all.js (or separate include)
I had to remove all jquery-ui/* AMD requirements from
gridstack.jQueryUI.js or I wasn't able to compile my apps
* now generate jquery-ui.min.js from src (hence demos updates)

will spin new NPM images next as I need these for my Angular apps.
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 66.52% when pulling c4d01bf on adumesny:develop into a5b6d4f on gridstack:develop.

@adumesny
adumesny merged commit 10715f2 into gridstack:develop Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants