openstack/db: add Trove backup strategy APIs#3811
Open
stias wants to merge 1 commit into
Open
Conversation
|
coverage: 63.545%. remained the same — stias:feature/trove-db-backup-strategies into gophercloud:main |
mandre
reviewed
Jun 29, 2026
| r.Err = err | ||
| return | ||
| } | ||
| resp, err := client.Post(ctx, baseURL(client), &b, &r.Body, &gophercloud.RequestOpts{OkCodes: []int{200}}) |
Contributor
There was a problem hiding this comment.
According to the docs, we should expect a 202 on success.
|
|
||
| // DeleteOpts represents options for deleting backup strategies. | ||
| type DeleteOpts struct { | ||
| // Delete the strategy for a particular database instance. |
Contributor
There was a problem hiding this comment.
Perhaps we should call out that by default, it deletes all strategies within a project if you don't specify an instance id?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3809
Split out from #3767.
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
https://github.com/openstack/trove/blob/stable/2026.1/trove/common/api.py#L210-L223
https://github.com/openstack/trove/blob/stable/2026.1/trove/backup/service.py#L132-L182
https://github.com/openstack/trove/blob/stable/2026.1/trove/backup/views.py#L60-L85