Baremetal V1 API Drivers - #1461
Merged
Merged
Conversation
|
Build failed.
|
elfosardo
force-pushed
the
baremetal-drivers
branch
from
February 21, 2019 09:08
65c3517 to
c01a5c2
Compare
|
Build failed.
|
elfosardo
force-pushed
the
baremetal-drivers
branch
from
February 21, 2019 10:05
c01a5c2 to
37f4d9d
Compare
|
Build failed.
|
elfosardo
force-pushed
the
baremetal-drivers
branch
from
February 21, 2019 13:27
37f4d9d to
05ec06e
Compare
|
Build failed.
|
elfosardo
force-pushed
the
baremetal-drivers
branch
2 times, most recently
from
February 21, 2019 14:20
c567c59 to
db7c7e2
Compare
elfosardo
force-pushed
the
baremetal-drivers
branch
from
February 21, 2019 14:50
db7c7e2 to
a6c2e45
Compare
|
Build failed.
|
elfosardo
force-pushed
the
baremetal-drivers
branch
from
February 22, 2019 07:55
a6c2e45 to
e7da7d3
Compare
|
Build failed.
|
elfosardo
force-pushed
the
baremetal-drivers
branch
from
February 24, 2019 20:46
e7da7d3 to
76ee5dd
Compare
|
Build succeeded.
|
dtantsur
approved these changes
Feb 25, 2019
elfosardo
force-pushed
the
baremetal-drivers
branch
from
February 25, 2019 12:22
76ee5dd to
e3d5dbd
Compare
|
Build succeeded.
|
61 tasks
jtopjian
requested changes
Mar 4, 2019
jtopjian
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure if this PR is ready for review. But if it is, I left a few comments. Please let me know if you have any questions.
elfosardo
force-pushed
the
baremetal-drivers
branch
2 times, most recently
from
March 5, 2019 09:13
f2f4fe9 to
95730c8
Compare
Contributor
Author
|
@jtopjian this PR is ready for review, thank you for your comments, I pushed some changes |
|
Build succeeded.
|
dtantsur
suggested changes
Mar 5, 2019
This patch adds the Drivers API calls according to Baremetal API reference [1] List Drivers (GET) Show driver details (GET) Show driver properties (GET) Show driver logical disk properties (GET) [1] https://developer.openstack.org/api-ref/baremetal/#drivers-drivers
elfosardo
force-pushed
the
baremetal-drivers
branch
from
March 5, 2019 13:10
95730c8 to
4168c0f
Compare
dtantsur
approved these changes
Mar 5, 2019
|
Build succeeded.
|
Contributor
|
@elfosardo Let me know if/when you're ready to have this merged :) |
Contributor
Author
|
@jtopjian this should be ready to be merged, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1429
This patch adds the Drivers API calls according to Baremetal API reference
List Drivers (GET)
Show driver details (GET)
Show driver properties (GET)
Show driver logical disk properties (GET)
Source code reference:
https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/driver.py