Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

fix: drop table compiler quoatation bug - #350

Closed
rkawajiri wants to merge 1 commit into
googleapis:mainfrom
rkawajiri:main
Closed

fix: drop table compiler quoatation bug#350
rkawajiri wants to merge 1 commit into
googleapis:mainfrom
rkawajiri:main

Conversation

@rkawajiri

@rkawajiri rkawajiri commented Oct 19, 2023

Copy link
Copy Markdown

Fixes googleapis/google-cloud-python#15682

  • Tests pass
    • lint (same error as main branch)
    • unit
    • migration_tests
    • compliance_test_13
    • compliance_test_14
    • compliance_test_20
  • Appropriate changes to README are included in PR

@google-cla

google-cla Bot commented Oct 19, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Oct 19, 2023
@rkawajiri
rkawajiri force-pushed the main branch 2 times, most recently from b47363d to 3fb4c44 Compare October 19, 2023 05:39
@rkawajiri rkawajiri changed the title use format_table for quotes use format_table for table name Oct 19, 2023
@rkawajiri rkawajiri changed the title use format_table for table name DDLCompiler: use format_table for table name Oct 19, 2023
@rkawajiri rkawajiri changed the title DDLCompiler: use format_table for table name DDLCompiler: fix drop table quoatation bug Oct 19, 2023
@rkawajiri rkawajiri changed the title DDLCompiler: fix drop table quoatation bug fix drop table quoatation bug Oct 19, 2023
@rkawajiri rkawajiri changed the title fix drop table quoatation bug fix: drop table compiler quoatation bug Oct 19, 2023
@rkawajiri rkawajiri closed this Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlalchemy.schema.DropTable compilation: Table name should be quoted by back quotes (`) on DROP TABLE

1 participant