samples: add code samples for PostgreSql dialect by rajatbhatta · Pull Request #836 · googleapis/python-spanner

rajatbhatta · 2022-10-04T06:09:30Z

No description provided.

snippet-bot · 2022-10-04T06:09:35Z

Here is the summary of changes.

You are about to add 44 region tags.

samples/samples/pg_snippets.py:35, tag spanner_postgresql_create_instance
samples/samples/pg_snippets.py:67, tag spanner_postgresql_create_database
samples/samples/pg_snippets.py:114, tag spanner_postgresql_insert_data
samples/samples/pg_snippets.py:156, tag spanner_postgresql_delete_data
samples/samples/pg_snippets.py:189, tag spanner_postgresql_query_data
samples/samples/pg_snippets.py:208, tag spanner_postgresql_read_data
samples/samples/pg_snippets.py:229, tag spanner_postgresql_add_column
samples/samples/pg_snippets.py:249, tag spanner_postgresql_update_data
samples/samples/pg_snippets.py:277, tag spanner_postgresql_read_write_transaction
samples/samples/pg_snippets.py:347, tag spanner_postgresql_query_data_with_new_column
samples/samples/pg_snippets.py:373, tag spanner_postgresql_create_index
samples/samples/pg_snippets.py:392, tag spanner_postgresql_read_data_with_index
samples/samples/pg_snippets.py:423, tag spanner_postgresql_create_storing_index
samples/samples/pg_snippets.py:446, tag spanner_postgresql_read_data_with_storing_index
samples/samples/pg_snippets.py:480, tag spanner_postgresql_read_only_transaction
samples/samples/pg_snippets.py:520, tag spanner_postgresql_dml_getting_started_insert
samples/samples/pg_snippets.py:543, tag spanner_postgresql_query_with_parameter
samples/samples/pg_snippets.py:564, tag spanner_postgresql_dml_getting_started_update
samples/samples/pg_snippets.py:625, tag spanner_postgresql_read_stale_data
samples/samples/pg_snippets.py:651, tag spanner_postgresql_update_data_with_timestamp_column
samples/samples/pg_snippets.py:689, tag spanner_postgresql_add_timestamp_column
samples/samples/pg_snippets.py:715, tag spanner_postgresql_query_data_with_timestamp_column
samples/samples/pg_snippets.py:746, tag spanner_postgresql_create_table_with_timestamp_column
samples/samples/pg_snippets.py:782, tag spanner_postgresql_insert_data_with_timestamp_column
samples/samples/pg_snippets.py:811, tag spanner_postgresql_dml_standard_insert
samples/samples/pg_snippets.py:833, tag spanner_postgresql_dml_standard_update
samples/samples/pg_snippets.py:856, tag spanner_postgresql_dml_standard_delete
samples/samples/pg_snippets.py:877, tag spanner_postgresql_dml_write_then_read
samples/samples/pg_snippets.py:906, tag spanner_postgresql_dml_partitioned_update
samples/samples/pg_snippets.py:924, tag spanner_postgresql_dml_partitioned_delete
samples/samples/pg_snippets.py:940, tag spanner_postgresql_dml_batch_update
samples/samples/pg_snippets.py:981, tag spanner_postgresql_create_table_with_datatypes
samples/samples/pg_snippets.py:1018, tag spanner_postgresql_insert_datatypes_data
samples/samples/pg_snippets.py:1081, tag spanner_postgresql_query_with_bool_parameter
samples/samples/pg_snippets.py:1107, tag spanner_postgresql_query_with_bytes_parameter
samples/samples/pg_snippets.py:1132, tag spanner_postgresql_query_with_float_parameter
samples/samples/pg_snippets.py:1159, tag spanner_postgresql_query_with_int_parameter
samples/samples/pg_snippets.py:1184, tag spanner_postgresql_query_with_string_parameter
samples/samples/pg_snippets.py:1209, tag spanner_postgresql_query_with_timestamp_parameter
samples/samples/pg_snippets.py:1222, tag spanner_postgresql_query_with_timestamp_parameter
samples/samples/pg_snippets.py:1239, tag spanner_postgresql_update_data_with_numeric_column
samples/samples/pg_snippets.py:1275, tag spanner_postgresql_query_with_numeric_parameter
samples/samples/pg_snippets.py:1300, tag spanner_postgresql_create_client_with_query_options
samples/samples/pg_snippets.py:1324, tag spanner_postgresql_query_with_query_options

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

linting

asthamohta · 2022-10-12T15:50:32Z

 # format = isort + black
 #

+


nit:remove extra line

asthamohta · 2022-10-12T15:53:02Z

+OPERATION_TIMEOUT_SECONDS = 240
+
+
+# [START spanner_postgresql_create_instance]


A pg instance is not required separately. You can reuse the same instance as google sql instance, and delete this test

asthamohta · 2022-10-12T15:53:45Z

+      database=database_name,
+      statements=[
+        """CREATE TABLE Singers (
+  SingerId   bigint NOT NULL,


nit: can you format this?

Also can you adda comment that pg is case insensitive or rename it to lower case

product-auto-label Bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Oct 4, 2022

samples: add code samples for PostgreSql dialect

83c023d

rajatbhatta force-pushed the pg-samples branch from 9c03359 to 83c023d Compare October 4, 2022 06:10

asthamohta and others added 6 commits October 4, 2022 13:07

linting

2b87cb0

Merge pull request #2 from asthamohta/pgSamples

4cba7f5

linting

Merge branch 'main' into pg-samples

840157d

fix: remove unnecessary imports

fc4a87f

Merge branch 'main' into pg-samples

ffee935

remove unused import

138ac42

rajatbhatta force-pushed the pg-samples branch from d2a9753 to 138ac42 Compare October 6, 2022 05:44

fix: change method doc references in parser

5a8a540

rajatbhatta added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 6, 2022

snippet-bot Bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 6, 2022

rajatbhatta added 3 commits October 6, 2022 06:05

add another command

e30729b

test: add samples tests for PG

9d08391

fix: linting

43f3918

rajatbhatta force-pushed the pg-samples branch from 8826ac2 to 43f3918 Compare October 6, 2022 14:44

rajatbhatta and others added 10 commits October 9, 2022 22:39

feat: sample tests config changes

078d8c8

Merge branch 'main' into pg-samples

38a26dc

refactor

9a7dc8f

refactor

921f8c9

refactor

12a39ac

refactor

3d53ddc

add database dialect

04f5028

database dialect fixture change

4073cb9

fix ddl

e590809

yield operation as well

c3305af

rajatbhatta added 3 commits October 10, 2022 08:49

config changes

24387e0

fix

78bb219

minor lint fix

3c80109

rajatbhatta marked this pull request as ready for review October 11, 2022 05:12

rajatbhatta requested a review from a team as a code owner October 11, 2022 05:12

rajatbhatta requested review from a team, asthamohta and loferris October 11, 2022 05:12

rajatbhatta added 3 commits October 11, 2022 07:42

some tests were getting skipped. fixing it.

289f305

fix test

9fbb899

fix test and skip few tests for faster testing

18367ba

rajatbhatta marked this pull request as draft October 11, 2022 12:38

re-enable tests

0c0cacb

rajatbhatta marked this pull request as ready for review October 11, 2022 14:03

rajatbhatta enabled auto-merge (squash) October 12, 2022 07:22

rajatbhatta disabled auto-merge October 12, 2022 14:14

asthamohta reviewed Oct 12, 2022

View reviewed changes

Comment thread samples/samples/noxfile.py

# format = isort + black

#

asthamohta Oct 12, 2022

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:remove extra line

asthamohta reviewed Oct 12, 2022

View reviewed changes

asthamohta added 2 commits October 26, 2022 13:09

Merge branch 'main' into pg-samples

749b539

Merge branch 'main' into pg-samples

9c50d44

asthamohta self-requested a review October 26, 2022 13:35

asthamohta approved these changes Oct 26, 2022

View reviewed changes

asthamohta added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 26, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022

asthamohta enabled auto-merge (squash) October 26, 2022 16:47

asthamohta added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2022

asthamohta merged commit fbb1440 into googleapis:main Oct 26, 2022

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2022

Navigation Menu

Uh oh!

samples: add code samples for PostgreSql dialect - #836

samples: add code samples for PostgreSql dialect#836
asthamohta merged 31 commits into
googleapis:mainfrom
rajatbhatta:pg-samples

rajatbhatta commented Oct 4, 2022

Uh oh!

snippet-bot Bot commented Oct 4, 2022 •

edited

Loading

Uh oh!

asthamohta Oct 12, 2022

Uh oh!

asthamohta Oct 12, 2022

Uh oh!

asthamohta Oct 12, 2022

Uh oh!

asthamohta Oct 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		OPERATION_TIMEOUT_SECONDS = 240


		# [START spanner_postgresql_create_instance]

Uh oh!

Conversation

rajatbhatta commented Oct 4, 2022

Uh oh!

snippet-bot Bot commented Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asthamohta Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

asthamohta Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

asthamohta Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

asthamohta Oct 12, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

snippet-bot Bot commented Oct 4, 2022 •

edited

Loading