Skip to content

fix: Refactor page.py to improve performance and organization #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
holtskinner merged 14 commits into from
Jul 2, 2024
Merged

fix: Refactor page.py to improve performance and organization #316

holtskinner merged 14 commits into from
Jul 2, 2024

Conversation

@holtskinner
Copy link
Member

@holtskinner holtskinner commented Jun 13, 2024 •
edited
Loading

Fixes #312 🦕

Improves upon the hOCR processing improvements made in #313

         22788704 function calls (19761621 primitive calls) in 6.297 seconds

@holtskinner holtskinner requested review from a team as code owners June 13, 2024 17:34
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 13, 2024
@holtskinner holtskinner requested a review from parthea June 13, 2024 18:50
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 14, 2024
@holtskinner holtskinner requested a review from dizcology June 14, 2024 17:10
@holtskinner holtskinner added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 1, 2024
dizcology
dizcology reviewed Jul 1, 2024
View reviewed changes
@dizcology
Copy link
Collaborator

dizcology commented Jul 1, 2024 •
edited
Loading

Please also say a few words (preferably as code comments) about what caused the slow performance in the original implementation, and which specific changes fixed it.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 1, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jul 1, 2024
@holtskinner holtskinner enabled auto-merge (squash) July 2, 2024 20:25
@holtskinner holtskinner disabled auto-merge July 2, 2024 20:42
@holtskinner holtskinner enabled auto-merge (squash) July 2, 2024 20:43
@holtskinner holtskinner merged commit bee4f62 into main Jul 2, 2024
@holtskinner holtskinner deleted the hocr-tables branch July 2, 2024 20:45
@release-please release-please bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizcology dizcology dizcology approved these changes

@parthea parthea Awaiting requested review from parthea

Assignees

@parthea parthea

@dizcology dizcology

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

High latency exporting to hocr

3 participants

@holtskinner @dizcology @parthea