fix: Change if condition typo in _get_children_of_element()
#313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #312 The previous `if` condition was inefficient and should have been written with an `and` This resulted in a large performance gap. cProfile timing of `export_hocr_string()` on the same document Before ``` 143598720 function calls (129111346 primitive calls) in 44.487 seconds ``` After ``` 7615212 function calls (7069249 primitive calls) in 2.921 seconds ```
parthea
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
ifcondition was inefficient and should have been written with anandThis resulted in a performance gap.cProfile timing of
export_hocr_string()on the same documentBefore
After
Fixes #312 🦕