This repository was archived by the owner on May 7, 2026. It is now read-only.
refactor: Tree traversals now non-recursive#1386
Merged
Merged
Conversation
af4acb5 to
e0691d1
Compare
sycai
reviewed
Feb 12, 2025
| from typing import Callable, Dict, Generator, Iterable, Mapping, Set, Tuple | ||
|
|
||
| import bigframes.core.guid | ||
| import bigframes.core.identifiers |
Contributor
There was a problem hiding this comment.
Here we have two imports for the same module.
Could you use from bigframes.core import identifiers and resolve all module references? go/pydev#imports
Contributor
Author
There was a problem hiding this comment.
ok, yeah, that is nicer, done
| for child in item.child_nodes: | ||
| yield (item, child) | ||
|
|
||
| def topo(self: BigFrameNode) -> Generator[BigFrameNode, None, None]: |
Contributor
There was a problem hiding this comment.
name suggestion: topo_ordered_nodes or get_nodes_in_topo_order or something similar to reflect the fact that we are returning a collection of nodes.
Contributor
Author
There was a problem hiding this comment.
renamed to iter_nodes_topo
Contributor
There was a problem hiding this comment.
Let's update the filename with anything that accurately describes the content, and preferably ends with "node"
Contributor
Author
There was a problem hiding this comment.
renamed to bigframe_node.py
sycai
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕