Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

refactor: Share logic between old and new aligner#1199

Merged
TrevorBergeron merged 2 commits into
mainfrom
rewrite_legacy
Dec 11, 2024
Merged

refactor: Share logic between old and new aligner#1199
TrevorBergeron merged 2 commits into
mainfrom
rewrite_legacy

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 9, 2024
@TrevorBergeron TrevorBergeron marked this pull request as ready for review December 10, 2024 23:32
@TrevorBergeron TrevorBergeron requested review from a team and tswast December 10, 2024 23:32
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TrevorBergeron TrevorBergeron enabled auto-merge (squash) December 11, 2024 20:18
@TrevorBergeron TrevorBergeron merged commit f200f68 into main Dec 11, 2024
@TrevorBergeron TrevorBergeron deleted the rewrite_legacy branch December 11, 2024 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants