Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: remove pre-caching of remote function results #1028

Merged
GarrettWu merged 1 commit into from
Oct 1, 2024
Merged

fix: remove pre-caching of remote function results #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions bigframes/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3567,11 +3567,7 @@ def apply(self, func, *, axis=0, args: typing.Tuple = (), **kwargs):
ops.NaryRemoteFunctionOp(func=func), series_list[1:]
)
result_series.name = None

# Return Series with materialized result so that any error in the remote
# function is caught early
materialized_series = result_series.cache()
return materialized_series
return result_series

# Per-column apply
results = {name: func(col, *args, **kwargs) for name, col in self.items()}
Expand Down
10 changes: 2 additions & 8 deletions bigframes/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,10 +1475,7 @@ def apply(
ops.RemoteFunctionOp(func=func, apply_on_null=True)
)

# return Series with materialized result so that any error in the remote
# function is caught early
materialized_series = result_series._cached(session_aware=False)
return materialized_series
return result_series

def combine(
self,
Expand Down Expand Up @@ -1506,10 +1503,7 @@ def combine(
other, ops.BinaryRemoteFunctionOp(func=func)
)

# return Series with materialized result so that any error in the remote
# function is caught early
materialized_series = result_series._cached()
return materialized_series
return result_series

@validations.requires_index
def add_prefix(self, prefix: str, axis: int | str | None = None) -> Series:
Expand Down