Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

test: disable deprecated embedding model tests#1006

Merged
GarrettWu merged 2 commits into
mainfrom
garrettwu-retire
Sep 20, 2024
Merged

test: disable deprecated embedding model tests#1006
GarrettWu merged 2 commits into
mainfrom
garrettwu-retire

Conversation

@GarrettWu
Copy link
Copy Markdown
Contributor

@GarrettWu GarrettWu commented Sep 20, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested review from a team, TrevorBergeron and shobsi September 20, 2024 20:34
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Sep 20, 2024
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 20, 2024
@GarrettWu GarrettWu changed the title test: disable deprecated embedding models test: disable deprecated embedding model tests Sep 20, 2024
@GarrettWu GarrettWu enabled auto-merge (squash) September 20, 2024 20:34
shobsi
shobsi reviewed Sep 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shobsi shobsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 tests marked deprecated are not the same as the 3 failing?

FAILED tests/system/small/ml/test_llm.py::test_create_text_embedding_generator_model_defaults
ERROR tests/system/small/ml/test_llm.py::test_create_embedding_generator_model_002
ERROR tests/system/small/ml/test_llm.py::test_create_embedding_generator_multilingual_model

@GarrettWu
Copy link
Copy Markdown
Contributor Author

GarrettWu commented Sep 20, 2024 •
edited
Loading

test_create_embedding_generator_multilingual_model

hmmm I retrieved from

https://fusion2.corp.google.com/ci/kokoro/prod:bigframes%2Fpresubmit%2Fpresubmit/activity/dfb811df-d049-4128-a7fe-76c35b698f94/invocations/dfb811df-d049-4128-a7fe-76c35b698f94/targets/bigframes%2Fpresubmit%2Fpresubmit/log

looks like test_create_embedding_generator_multilingual_model is also failing.

I'll do a further check.

@GarrettWu GarrettWu disabled auto-merge September 20, 2024 20:47
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Sep 20, 2024
@GarrettWu GarrettWu requested a review from shobsi September 20, 2024 21:06
@GarrettWu GarrettWu enabled auto-merge (squash) September 20, 2024 21:06
@GarrettWu GarrettWu merged commit 8520873 into main Sep 20, 2024
@GarrettWu GarrettWu deleted the garrettwu-retire branch September 20, 2024 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

2 more reviewers

@tswast tswast tswast approved these changes

@shobsi shobsi shobsi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TrevorBergeron TrevorBergeron

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GarrettWu @tswast @shobsi @TrevorBergeron