Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

refactor: re-arrange describe() logic into two helper methods#1005

Merged
sycai merged 3 commits into
mainfrom
sycai-refactor-describe
Sep 24, 2024
Merged

refactor: re-arrange describe() logic into two helper methods#1005
sycai merged 3 commits into
mainfrom
sycai-refactor-describe

Conversation

@sycai
Copy link
Copy Markdown
Contributor

@sycai sycai commented Sep 20, 2024

It feels like an overkill to introduce class-level constants.

@sycai sycai requested review from a team and tswast September 20, 2024 18:06
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Sep 20, 2024
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 20, 2024
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

@sycai sycai merged commit 5c1a4c7 into main Sep 24, 2024
@sycai sycai deleted the sycai-refactor-describe branch September 24, 2024 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants