This repository was archived by the owner on Feb 23, 2026. It is now read-only.
feat: add universe_domain argument to ClientOptions - #546
Merged
Conversation
ohmayr
marked this pull request as ready for review
November 20, 2023 16:37
…om:googleapis/python-api-core into feature/add-universe-domain-option-for-tpc
parthea
reviewed
Nov 20, 2023
ohmayr
force-pushed
the
feature/add-universe-domain-option-for-tpc
branch
from
November 20, 2023 18:04
6659f20 to
193ebe0
Compare
ohmayr
force-pushed
the
feature/add-universe-domain-option-for-tpc
branch
from
November 20, 2023 18:24
bf0d17a to
bdafd5f
Compare
parthea
reviewed
Nov 20, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547 🦕
BEGIN_COMMIT_OVERRIDE
feat: add universe_domain argument to ClientOptions
END_COMMIT_OVERRIDE