Skip to content

fix: Set request content-type encoding to UTF-8 - #56

Merged
jaycee-li merged 1 commit into
googleapis:mainfrom
jclab-joseph:fix/request-encoding
Feb 10, 2025
Merged

fix: Set request content-type encoding to UTF-8#56
jaycee-li merged 1 commit into
googleapis:mainfrom
jclab-joseph:fix/request-encoding

Conversation

@jclab-joseph

@jclab-joseph jclab-joseph commented Feb 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Do not use new StringEntity without specifying a ContentType.

All non-English characters, are broken because of the code below.

TEXT_PLAIN = create("text/plain", Consts.ISO_8859_1);
DEFAULT_TEXT = TEXT_PLAIN;
public StringEntity(String string) throws UnsupportedEncodingException {
    this(string, ContentType.DEFAULT_TEXT);
}

ContentType.APPLICATION_JSON uses UTF-8.

jaycee-li
jaycee-li approved these changes Feb 10, 2025
View reviewed changes

@jaycee-li jaycee-li left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jaycee-li
jaycee-li merged commit 09329f7 into googleapis:main Feb 10, 2025
copybara-service Bot pushed a commit that referenced this pull request Feb 10, 2025
@google-genai-bot @copybara-github
No public description
02ac9fb 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#56 from jclab-joseph:fix/request-encoding 9d24c42
PiperOrigin-RevId: 725317115
@copybara-service copybara-service Bot mentioned this pull request Feb 10, 2025
Merged
copybara-service Bot pushed a commit that referenced this pull request Feb 11, 2025
@google-genai-bot @copybara-github
feat: Enable Media resolution for Gemini API.
d65b68e 
FUTURE_COPYBARA_INTEGRATE_REVIEW=#56 from jclab-joseph:fix/request-encoding 9d24c42
PiperOrigin-RevId: 725317115
@release-please release-please Bot mentioned this pull request Feb 13, 2025
Closed
This was referenced Feb 20, 2025
Closed
Closed
Closed
Merged
@release-please release-please Bot mentioned this pull request Jul 16, 2025
Closed
@release-please release-please Bot mentioned this pull request Sep 3, 2025
Merged
@release-please release-please Bot mentioned this pull request Sep 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaycee-li jaycee-li jaycee-li approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jclab-joseph @jaycee-li