chore(bigframes): move some ai accessor tests outside the SQLGlot compiler dir#17318
Open
sycai wants to merge 4 commits into
Open
chore(bigframes): move some ai accessor tests outside the SQLGlot compiler dir#17318sycai wants to merge 4 commits into
sycai wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request relocates several AI-related unit tests from packages/bigframes/tests/unit/core/compile/sqlglot/test_dataframe_accessor.py to a new test file under packages/bigframes/tests/unit/extensions/core/test_dataframe_accessor.py. The review feedback identifies several clean-up opportunities in the moved tests, including removing unused snapshot fixtures, resolving a duplicate import of bigframes.bigquery.ai, and removing unused session mocks along with their trivial assert_not_called() assertions in the test_bigframes_ai_generate_* test cases.
…ccessor.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ccessor.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests do not generate golden SQLs, so it makes less sense to place them under the SQLGlot test directory.
This is a follow-up to #17302