Skip to content

feat: [monitoring-dashboards] added support for horizontal bar rendering and column settings on time series tables #8975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeWang1127 merged 2 commits into from
Jan 11, 2023
Merged

feat: [monitoring-dashboards] added support for horizontal bar rendering and column settings on time series tables #8975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da7b0c9
feat: added support for horizontal bar rendering and column settings …
gcf-owl-bot[bot] Jan 11, 2023
ccae3d9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions java-monitoring-dashboards/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ If you are using Maven, add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-monitoring-dashboard</artifactId>
<version>2.8.0</version>
<version>2.9.0</version>
</dependency>
```

If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-monitoring-dashboard:2.8.0'
implementation 'com.google.cloud:google-cloud-monitoring-dashboard:2.9.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-monitoring-dashboard" % "2.8.0"
libraryDependencies += "com.google.cloud" % "google-cloud-monitoring-dashboard" % "2.9.0"
```

## Authentication
Expand Down
32 changes: 24 additions & 8 deletions ...-dashboard-v1/src/main/java/com/google/monitoring/dashboard/v1/DashboardsServiceGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,12 @@ public abstract static class DashboardsServiceImplBase implements io.grpc.Bindab
*
*
* <pre>
* Creates a new custom dashboard. For examples on how you can use this API to create dashboards, see [Managing dashboards by API](https://cloud.google.com/monitoring/dashboards/api-dashboard).
* This method requires the `monitoring.dashboards.create` permission on the specified project. For more information about permissions, see [Cloud Identity and Access Management](https://cloud.google.com/iam).
* Creates a new custom dashboard. For examples on how you can use this API to
* create dashboards, see [Managing dashboards by
* API](https://cloud.google.com/monitoring/dashboards/api-dashboard). This
* method requires the `monitoring.dashboards.create` permission on the
* specified project. For more information about permissions, see [Cloud
* Identity and Access Management](https://cloud.google.com/iam).
* </pre>
*/
public void createDashboard(
Expand Down Expand Up @@ -466,8 +470,12 @@ protected DashboardsServiceStub build(
*
*
* <pre>
* Creates a new custom dashboard. For examples on how you can use this API to create dashboards, see [Managing dashboards by API](https://cloud.google.com/monitoring/dashboards/api-dashboard).
* This method requires the `monitoring.dashboards.create` permission on the specified project. For more information about permissions, see [Cloud Identity and Access Management](https://cloud.google.com/iam).
* Creates a new custom dashboard. For examples on how you can use this API to
* create dashboards, see [Managing dashboards by
* API](https://cloud.google.com/monitoring/dashboards/api-dashboard). This
* method requires the `monitoring.dashboards.create` permission on the
* specified project. For more information about permissions, see [Cloud
* Identity and Access Management](https://cloud.google.com/iam).
* </pre>
*/
public void createDashboard(
Expand Down Expand Up @@ -585,8 +593,12 @@ protected DashboardsServiceBlockingStub build(
*
*
* <pre>
* Creates a new custom dashboard. For examples on how you can use this API to create dashboards, see [Managing dashboards by API](https://cloud.google.com/monitoring/dashboards/api-dashboard).
* This method requires the `monitoring.dashboards.create` permission on the specified project. For more information about permissions, see [Cloud Identity and Access Management](https://cloud.google.com/iam).
* Creates a new custom dashboard. For examples on how you can use this API to
* create dashboards, see [Managing dashboards by
* API](https://cloud.google.com/monitoring/dashboards/api-dashboard). This
* method requires the `monitoring.dashboards.create` permission on the
* specified project. For more information about permissions, see [Cloud
* Identity and Access Management](https://cloud.google.com/iam).
* </pre>
*/
public com.google.monitoring.dashboard.v1.Dashboard createDashboard(
Expand Down Expand Up @@ -684,8 +696,12 @@ protected DashboardsServiceFutureStub build(
*
*
* <pre>
* Creates a new custom dashboard. For examples on how you can use this API to create dashboards, see [Managing dashboards by API](https://cloud.google.com/monitoring/dashboards/api-dashboard).
* This method requires the `monitoring.dashboards.create` permission on the specified project. For more information about permissions, see [Cloud Identity and Access Management](https://cloud.google.com/iam).
* Creates a new custom dashboard. For examples on how you can use this API to
* create dashboards, see [Managing dashboards by
* API](https://cloud.google.com/monitoring/dashboards/api-dashboard). This
* method requires the `monitoring.dashboards.create` permission on the
* specified project. For more information about permissions, see [Cloud
* Identity and Access Management](https://cloud.google.com/iam).
* </pre>
*/
public com.google.common.util.concurrent.ListenableFuture<
Expand Down
56 changes: 39 additions & 17 deletions ...-monitoring-dashboard-v1/src/main/java/com/google/monitoring/dashboard/v1/TableProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ public static void registerAllExtensions(com.google.protobuf.ExtensionRegistry r
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_TableDataSet_descriptor;
static final com.google.protobuf.GeneratedMessageV3.FieldAccessorTable
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_TableDataSet_fieldAccessorTable;
static final com.google.protobuf.Descriptors.Descriptor
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_ColumnSettings_descriptor;
static final com.google.protobuf.GeneratedMessageV3.FieldAccessorTable
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_ColumnSettings_fieldAccessorTable;

public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
return descriptor;
Expand All @@ -50,23 +54,31 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "nitoring/dashboard/v1/metrics.proto\032:goo"
+ "gle/monitoring/dashboard/v1/table_displa"
+ "y_options.proto\032\036google/protobuf/duratio"
+ "n.proto\"\375\002\n\017TimeSeriesTable\022T\n\tdata_sets"
+ "n.proto\"\322\005\n\017TimeSeriesTable\022T\n\tdata_sets"
+ "\030\001 \003(\0132<.google.monitoring.dashboard.v1."
+ "TimeSeriesTable.TableDataSetB\003\340A\002\032\223\002\n\014Ta"
+ "bleDataSet\022O\n\021time_series_query\030\001 \001(\0132/."
+ "google.monitoring.dashboard.v1.TimeSerie"
+ "sQueryB\003\340A\002\022\033\n\016table_template\030\002 \001(\tB\003\340A\001"
+ "\022<\n\024min_alignment_period\030\003 \001(\0132\031.google."
+ "protobuf.DurationB\003\340A\001\022W\n\025table_display_"
+ "options\030\004 \001(\01323.google.monitoring.dashbo"
+ "ard.v1.TableDisplayOptionsB\003\340A\001B\364\001\n\"com."
+ "google.monitoring.dashboard.v1B\nTablePro"
+ "toP\001ZGgoogle.golang.org/genproto/googlea"
+ "pis/monitoring/dashboard/v1;dashboard\252\002$"
+ "Google.Cloud.Monitoring.Dashboard.V1\312\002$G"
+ "oogle\\Cloud\\Monitoring\\Dashboard\\V1\352\002(Go"
+ "ogle::Cloud::Monitoring::Dashboard::V1b\006"
+ "proto3"
+ "TimeSeriesTable.TableDataSetB\003\340A\002\022f\n\024met"
+ "ric_visualization\030\002 \001(\0162C.google.monitor"
+ "ing.dashboard.v1.TimeSeriesTable.MetricV"
+ "isualizationB\003\340A\001\022\\\n\017column_settings\030\004 \003"
+ "(\0132>.google.monitoring.dashboard.v1.Time"
+ "SeriesTable.ColumnSettingsB\003\340A\001\032\223\002\n\014Tabl"
+ "eDataSet\022O\n\021time_series_query\030\001 \001(\0132/.go"
+ "ogle.monitoring.dashboard.v1.TimeSeriesQ"
+ "ueryB\003\340A\002\022\033\n\016table_template\030\002 \001(\tB\003\340A\001\022<"
+ "\n\024min_alignment_period\030\003 \001(\0132\031.google.pr"
+ "otobuf.DurationB\003\340A\001\022W\n\025table_display_op"
+ "tions\030\004 \001(\01323.google.monitoring.dashboar"
+ "d.v1.TableDisplayOptionsB\003\340A\001\032;\n\016ColumnS"
+ "ettings\022\023\n\006column\030\001 \001(\tB\003\340A\002\022\024\n\007visible\030"
+ "\002 \001(\010B\003\340A\002\"P\n\023MetricVisualization\022$\n MET"
+ "RIC_VISUALIZATION_UNSPECIFIED\020\000\022\n\n\006NUMBE"
+ "R\020\001\022\007\n\003BAR\020\002B\364\001\n\"com.google.monitoring.d"
+ "ashboard.v1B\nTableProtoP\001ZGgoogle.golang"
+ ".org/genproto/googleapis/monitoring/dash"
+ "board/v1;dashboard\252\002$Google.Cloud.Monito"
+ "ring.Dashboard.V1\312\002$Google\\Cloud\\Monitor"
+ "ing\\Dashboard\\V1\352\002(Google::Cloud::Monito"
+ "ring::Dashboard::V1b\006proto3"
};
descriptor =
com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(
Expand All @@ -83,7 +95,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
new com.google.protobuf.GeneratedMessageV3.FieldAccessorTable(
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_descriptor,
new java.lang.String[] {
"DataSets",
"DataSets", "MetricVisualization", "ColumnSettings",
});
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_TableDataSet_descriptor =
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_descriptor
Expand All @@ -95,6 +107,16 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
new java.lang.String[] {
"TimeSeriesQuery", "TableTemplate", "MinAlignmentPeriod", "TableDisplayOptions",
});
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_ColumnSettings_descriptor =
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_descriptor
.getNestedTypes()
.get(1);
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_ColumnSettings_fieldAccessorTable =
new com.google.protobuf.GeneratedMessageV3.FieldAccessorTable(
internal_static_google_monitoring_dashboard_v1_TimeSeriesTable_ColumnSettings_descriptor,
new java.lang.String[] {
"Column", "Visible",
});
com.google.protobuf.ExtensionRegistry registry =
com.google.protobuf.ExtensionRegistry.newInstance();
registry.add(com.google.api.FieldBehaviorProto.fieldBehavior);
Expand Down
43 changes: 25 additions & 18 deletions ...oring-dashboard-v1/src/main/java/com/google/monitoring/dashboard/v1/TimeSeriesFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ public OutputFilterCase getOutputFilterCase() {
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -148,8 +149,9 @@ public java.lang.String getFilter() {
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand Down Expand Up @@ -338,7 +340,7 @@ public com.google.monitoring.dashboard.v1.PickTimeSeriesFilter getPickTimeSeries
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilter.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=79
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=80
* @return Whether the statisticalTimeSeriesFilter field is set.
*/
@java.lang.Override
Expand All @@ -359,7 +361,7 @@ public boolean hasStatisticalTimeSeriesFilter() {
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilter.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=79
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=80
* @return The statisticalTimeSeriesFilter.
*/
@java.lang.Override
Expand Down Expand Up @@ -910,8 +912,9 @@ public Builder clearOutputFilter() {
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -933,8 +936,9 @@ public java.lang.String getFilter() {
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -956,8 +960,9 @@ public com.google.protobuf.ByteString getFilterBytes() {
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -978,8 +983,9 @@ public Builder setFilter(java.lang.String value) {
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -996,8 +1002,9 @@ public Builder clearFilter() {
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand Down Expand Up @@ -1650,7 +1657,7 @@ public Builder clearPickTimeSeriesFilter() {
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilter.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=79
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=80
* @return Whether the statisticalTimeSeriesFilter field is set.
*/
@java.lang.Override
Expand All @@ -1671,7 +1678,7 @@ public boolean hasStatisticalTimeSeriesFilter() {
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilter.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=79
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=80
* @return The statisticalTimeSeriesFilter.
*/
@java.lang.Override
Expand Down
14 changes: 8 additions & 6 deletions ...hboard-v1/src/main/java/com/google/monitoring/dashboard/v1/TimeSeriesFilterOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ public interface TimeSeriesFilterOrBuilder
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand All @@ -40,8 +41,9 @@ public interface TimeSeriesFilterOrBuilder
*
*
* <pre>
* Required. The [monitoring filter](https://cloud.google.com/monitoring/api/v3/filters)
* that identifies the metric types, resources, and projects to query.
* Required. The [monitoring
* filter](https://cloud.google.com/monitoring/api/v3/filters) that identifies
* the metric types, resources, and projects to query.
* </pre>
*
* <code>string filter = 1 [(.google.api.field_behavior) = REQUIRED];</code>
Expand Down Expand Up @@ -175,7 +177,7 @@ public interface TimeSeriesFilterOrBuilder
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilter.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=79
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=80
* @return Whether the statisticalTimeSeriesFilter field is set.
*/
@java.lang.Deprecated
Expand All @@ -193,7 +195,7 @@ public interface TimeSeriesFilterOrBuilder
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilter.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=79
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=80
* @return The statisticalTimeSeriesFilter.
*/
@java.lang.Deprecated
Expand Down
8 changes: 4 additions & 4 deletions ...-dashboard-v1/src/main/java/com/google/monitoring/dashboard/v1/TimeSeriesFilterRatio.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,7 @@ public com.google.monitoring.dashboard.v1.PickTimeSeriesFilter getPickTimeSeries
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilterRatio.statistical_time_series_filter
* is deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=118
* is deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=120
* @return Whether the statisticalTimeSeriesFilter field is set.
*/
@java.lang.Override
Expand All @@ -1345,7 +1345,7 @@ public boolean hasStatisticalTimeSeriesFilter() {
* </code>
*
* @deprecated google.monitoring.dashboard.v1.TimeSeriesFilterRatio.statistical_time_series_filter
* is deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=118
* is deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=120
* @return The statisticalTimeSeriesFilter.
*/
@java.lang.Override
Expand Down Expand Up @@ -2722,7 +2722,7 @@ public Builder clearPickTimeSeriesFilter() {
*
* @deprecated
* google.monitoring.dashboard.v1.TimeSeriesFilterRatio.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=118
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=120
* @return Whether the statisticalTimeSeriesFilter field is set.
*/
@java.lang.Override
Expand All @@ -2744,7 +2744,7 @@ public boolean hasStatisticalTimeSeriesFilter() {
*
* @deprecated
* google.monitoring.dashboard.v1.TimeSeriesFilterRatio.statistical_time_series_filter is
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=118
* deprecated. See google/monitoring/dashboard/v1/metrics.proto;l=120
* @return The statisticalTimeSeriesFilter.
*/
@java.lang.Override
Expand Down
Loading