Skip to content

Parse compute resource names [DO NOT MERGE] - #4208

Closed
andreamlin wants to merge 1 commit into
googleapis:regen_computefrom
andreamlin:parse_compute_resource_names
Closed

Parse compute resource names [DO NOT MERGE]#4208
andreamlin wants to merge 1 commit into
googleapis:regen_computefrom
andreamlin:parse_compute_resource_names

Conversation

@andreamlin

@andreamlin andreamlin commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

This is a sample regeneration of google-cloud-compute using artman with googleapis/api-common-java#68 and googleapis/discovery-artifact-manager#102.

In addition to the generated changes, ITComputeTest has been manually changed to remove the trimUrl() hack that manually removed the service address from resource paths.

@andreamlin
andreamlin requested a review from a team December 11, 2018 00:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2018
@andreamlin
andreamlin removed the request for review from a team December 11, 2018 00:47
@andreamlin andreamlin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 11, 2018
}

/** For a given resource's URI, trim the path until it contains only the PathTemplate string. */
private static String trimUrl(String url) {

This comment was marked as spam.

@andreamlin andreamlin closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants