Skip to content

V3 remove deprecated bigtable admin #15908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
scotthart wants to merge 9 commits into
base: prepare-for-v3.0.0
Choose a base branch
from
Draft

V3 remove deprecated bigtable admin #15908

scotthart wants to merge 9 commits into from

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Jan 26, 2026

No description provided.

@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 26, 2026

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request advances the V3 migration by systematically removing outdated Bigtable admin client interfaces. It ensures that the codebase, particularly the integration tests, aligns with the new, more consistent client libraries for Bigtable administration, and provides clear guidance for users transitioning to these updated APIs.

Highlights

  • Deprecation and Removal of Legacy Bigtable Admin Clients: The bigtable::AdminClient, bigtable::TableAdmin, and bigtable::InstanceAdmin classes have been effectively removed from the codebase by wrapping their definitions and associated test files in #if 0 preprocessor directives. This marks their full deprecation in favor of newer client interfaces.
  • Migration to Modern Bigtable Admin Clients: Integration tests have been updated to utilize the modern bigtable_admin::BigtableTableAdminClient and bigtable_admin::BigtableInstanceAdminClient classes, demonstrating the correct usage of the new APIs.
  • Updated Migration Guide: A new section has been added to the doc/v3-migration-guide.md to guide users on migrating from the removed bigtable::AdminClient to bigtable_admin::BigtableTableAdminClient, including 'Before' and 'After' code examples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 26, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the codebase from deprecated bigtable::AdminClient and related classes to the new bigtable_admin::BigtableTableAdminClient and bigtable_admin::BigtableInstanceAdminClient APIs. The changes involve updating includes, member variable types, and method calls in integration tests to reflect the new API structure. Additionally, several old files and integration tests have been commented out using #if 0 directives, indicating their deprecation and removal. The v3-migration-guide.md has been updated to provide clear instructions for users migrating to the new API, which is a valuable addition for maintainability and user experience.

doc/v3-migration-guide.md Outdated
<details>
<summary>Removed <code>bigtable::AdminClient</code></summary>

The `bigtable::AdminClient` class has been removed in and replaced with
Copy link

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing "removed in and replaced with" sounds a bit awkward. Consider rephrasing for better clarity.

Suggested change
The `bigtable::AdminClient` class has been removed in and replaced with
The `bigtable::AdminClient` class has been removed and replaced with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@scotthart