This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: signBytes for impersonated credentials - #506
Merged
arithmetic1728 merged 3 commits intoMay 15, 2020
Merged
Conversation
maroux
force-pushed
the
fix_impersonated_credentials_signbytes
branch
from
May 7, 2020 01:54
cec645e to
2b85d0c
Compare
arithmetic1728
self-requested a review
May 7, 2020 17:11
arithmetic1728
approved these changes
May 7, 2020
Contributor
Author
|
@arithmetic1728 can we get this merged please? Thanks! |
Contributor
|
@maroux It seems lint check failed in your PR. Could you run Thanks. |
Contributor
Author
|
@arithmetic1728 done. |
Contributor
|
@maroux the fix is released in v1.15.0 |
Contributor
Author
|
awesome, thanks @arithmetic1728 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338