Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: in token endpoint request, do not decode the response data if it is not encoded - #392

Closed
CodingFanSteve wants to merge 0 commit into
googleapis:masterfrom
CodingFanSteve:fix-refresh
Closed

fix: in token endpoint request, do not decode the response data if it is not encoded#392
CodingFanSteve wants to merge 0 commit into
googleapis:masterfrom
CodingFanSteve:fix-refresh

Conversation

@CodingFanSteve

Copy link
Copy Markdown
Contributor

The interface of the underlying transport 'google.auth.transport.Request' that makes the token
request does not guarantee the response is encoded. In Python 3, the
non-encoded strings do not have 'decode' attribute. Blindly decoding all
the response could have the token refresh throw here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2019
@CodingFanSteve CodingFanSteve changed the title In token endpoint request, DO NOT decode the response data if it is not encoded. fix: In token endpoint request, DO NOT decode the response data if it is not encoded. Nov 26, 2019
@CodingFanSteve CodingFanSteve changed the title fix: In token endpoint request, DO NOT decode the response data if it is not encoded. fix: In token endpoint request, DO NOT decode the response data if it is not encoded Nov 26, 2019
@CodingFanSteve CodingFanSteve changed the title fix: In token endpoint request, DO NOT decode the response data if it is not encoded fix: In token endpoint request, do not decode the response data if it is not encoded Nov 26, 2019
@CodingFanSteve CodingFanSteve changed the title fix: In token endpoint request, do not decode the response data if it is not encoded fix: in token endpoint request, do not decode the response data if it is not encoded Nov 26, 2019
@CodingFanSteve
CodingFanSteve deleted the fix-refresh branch November 26, 2019 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants