fix: replace deprecated utcfromtimestamp #1799

andriawang6 · 2025-07-30T00:52:59Z

addresses googleapis/google-cloud-python#15145

Moves away from using utcfromtimestamp() in the datetime library due to deprecation.
Adds a new helper function to manage internal handling of timezone aware versus timezone naive timestamps.

DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).

Failing tests due to not stripping tzinfo

gkevinzheng · 2025-12-18T16:38:23Z

Hi @andriawang6,

I don't think you can simply replace utcfromtimestamp with fromtimestamp(tz=datetime.timezone.utc) since utcfromtimestamp is not offset aware, whereas fromtimestamp is. This causes issues with comparing timestamps. We've resolved a similar issue in the past (see this discussion) by adding a .replace(tzinfo=None) after creating the timestamp object with fromtimestamp(tz=datetime.timezone.utc). You can add it to google/auth/_helpers.py like we did the function definition for utcnow

Also see this PR: #1413

parthea · 2026-01-05T17:38:42Z

tests_async/oauth2/test__client_async.py

    assert token == id_token
    # JWT does not store microseconds
-    now = now.replace(microsecond=0)
+    now = now.replace(microsecond=0).replace(tzinfo=None)


Following up on offline discussion, tests pass regardless of the changes in tests_async/oauth2/test__client_async.py. Revert this file as it appears to be noise

parthea · 2026-01-05T17:39:06Z

tests/compute_engine/test_credentials.py

    @mock.patch(
        "google.auth._helpers.utcnow",
-        return_value=datetime.datetime.utcfromtimestamp(0),
+        return_value=datetime.datetime.fromtimestamp(0, tz=datetime.timezone.utc),


use _helpers.utcfromtimestamp . Applies throughout

parthea · 2026-01-05T17:43:06Z

Switching to draft while review comments are being addressed

parthea · 2026-01-08T15:09:38Z

tests/oauth2/test__client.py


 def test_call_iam_generate_id_token_endpoint():
-    now = _helpers.utcnow()
+    now = _helpers.utcnow().astimezone(datetime.timezone.utc)


Tests pass without the changes to tests/oauth2/test__client.py . Let's revert all of the changes in tests/oauth2/test__client.py

… of this PR

PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209 <details><summary>google-auth: 2.48.0</summary> ## [2.48.0](v2.47.0...v2.48.0) (2026-01-21) ### Features * honor `NO_GCE_CHECK` environment variable (#1610) ([383c982](383c9827)) * add configurable GCE Metadata Server retries (#1488) ([454b441](454b441b)) * add cryptography as required dependency (#1929) ([52558ae](52558ae2)) * Support the mTLS IAM domain for Certificate based Access (#1938) ([8dcf91a](8dcf91a1)) ### Bug Fixes * resolve circular imports (#1942) ([25c1b06](25c1b064)) * Use `user_verification=preferred` for ReAuth WebAuthn challenge (#1798) ([3f88a24](3f88a240)) * removes `content-header` from AWS IMDS get request (#1934) ([97bfea9](97bfea9e)) * detect correct auth when ADC env var is set but empty (#1374) ([bfc07e1](bfc07e10)) * replace deprecated utcfromtimestamp (#1799) ([e431f20](e431f20c)) </details>

chore: replace deprecated utcfromtimestamp

250f015

andriawang6 force-pushed the replace-utcfromtimestamp branch from 687ac1a to 250f015 Compare July 30, 2025 00:58

andriawang6 marked this pull request as ready for review July 30, 2025 01:06

andriawang6 requested review from a team as code owners July 30, 2025 01:06

Merge branch 'main' into replace-utcfromtimestamp

0181b9c

gkevinzheng requested a review from a team as a code owner December 17, 2025 19:26

gkevinzheng previously approved these changes Dec 17, 2025

View reviewed changes

gkevinzheng changed the title ~~replace deprecated utcfromtimestamp~~ fix: replace deprecated utcfromtimestamp Dec 17, 2025

parthea previously approved these changes Dec 17, 2025

View reviewed changes

parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 17, 2025

yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 17, 2025

gkevinzheng enabled auto-merge (squash) December 17, 2025 19:35

parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 17, 2025

parthea disabled auto-merge December 17, 2025 20:50

parthea self-assigned this Dec 17, 2025

Merge branch 'main' into replace-utcfromtimestamp

56c135a

Merge branch 'main' into replace-utcfromtimestamp

f0cd184

chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2025

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 29, 2025

fix: updates with helper function for utcfromtimestamp

16616cc

chalmerlowe dismissed parthea’s stale review via 16616cc December 29, 2025 14:12

chalmerlowe added 3 commits December 29, 2025 09:56

fix: remove unneeded import

e186d3f

fix: update blank line

0da5e38

fix: restore accidently deleted import: copy

4109407

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2026

daniel-sanche previously approved these changes Jan 5, 2026

View reviewed changes

parthea reviewed Jan 5, 2026

View reviewed changes

parthea marked this pull request as draft January 5, 2026 17:42

chalmerlowe added 2 commits January 5, 2026 16:22

reverts back in order to remove unneeded mods to test_client_async.py

4d552d1

ensures that the new helper is used universally

3cd7e3d

chalmerlowe dismissed stale reviews from daniel-sanche and themself via 3cd7e3d January 5, 2026 23:13

chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2026

Merge branch 'main' into replace-utcfromtimestamp

098fddc

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2026

chalmerlowe marked this pull request as ready for review January 6, 2026 00:08

chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2026

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 7, 2026

Merge branch 'main' into replace-utcfromtimestamp

c08a16d

chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2026

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2026

parthea reviewed Jan 8, 2026

View reviewed changes

chalmerlowe added 2 commits January 8, 2026 10:18

Merge branch 'main' into replace-utcfromtimestamp

d501661

removes updates accidnetally added during experimentation and testing…

47555de

… of this PR

chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2026

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2026

parthea approved these changes Jan 8, 2026

View reviewed changes

parthea requested a review from Linchin January 8, 2026 16:08

Linchin approved these changes Jan 9, 2026

View reviewed changes

chalmerlowe merged commit e431f20 into googleapis:main Jan 9, 2026
15 of 16 checks passed

daniel-sanche mentioned this pull request Jan 22, 2026

chore: librarian release pull request: 20260121T162706Z #1946

Merged

daniel-sanche mentioned this pull request Jan 26, 2026

chore: librarian release pull request: 20260126T120558Z #1947

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: replace deprecated utcfromtimestamp #1799

fix: replace deprecated utcfromtimestamp #1799

andriawang6 commented Jul 30, 2025 •

edited by chalmerlowe

Loading

Uh oh!

gkevinzheng commented Dec 18, 2025 •

edited

Loading

Uh oh!

parthea Jan 5, 2026

Uh oh!

chalmerlowe Jan 7, 2026

Uh oh!

parthea Jan 5, 2026

Uh oh!

chalmerlowe Jan 7, 2026

Uh oh!

parthea commented Jan 5, 2026

Uh oh!

parthea Jan 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fix: replace deprecated utcfromtimestamp #1799

fix: replace deprecated utcfromtimestamp #1799

Conversation

andriawang6 commented Jul 30, 2025 • edited by chalmerlowe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gkevinzheng commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parthea Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

chalmerlowe Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

parthea Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

chalmerlowe Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

parthea commented Jan 5, 2026

Uh oh!

parthea Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

andriawang6 commented Jul 30, 2025 •

edited by chalmerlowe

Loading

gkevinzheng commented Dec 18, 2025 •

edited

Loading

parthea Jan 8, 2026 •

edited

Loading