Fix for java.security.SignatureException: Signature length not correct - #946
Closed
davidpaniz wants to merge 1 commit into
Closed
Fix for java.security.SignatureException: Signature length not correct#946davidpaniz wants to merge 1 commit into
davidpaniz wants to merge 1 commit into
Conversation
|
@davidpaniz if you haven't, it looks like you need to follow https://developers.google.com/api-client-library/java/google-api-java-client/contribute |
Author
|
Hi @aaronharnly, I really skipped all the steps, sorry about that. This PR fixes #947, I did it in a rush to solve a production issue and thought it might be helpful to you. Maybe you can just close this PR and use the main ideia to solve the issue. In the meantime I will follow the steps to contribute to the project. |
Contributor
|
We'll be putting a try-catch around google-http-client's SecurityUtils.verify to fix the issue in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a few hour ago, oath integration with google is not working because a exception
java.security.SignatureException: Signature length not correct: got 256 but was expecting 128This solution is based on this comment http://stackoverflow.com/questions/30780407/google-oauth2-jwt-token-verification-exception
If a exception is thrown while checking keys, it returns false instead of break.