-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: mongodb driver version bump to v2 #2349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dennisg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant dependency upgrade, moving the project's MongoDB Go driver to its second major version, Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates the MongoDB driver to v2, which involves necessary changes to import paths and function signatures. Most of the changes correctly reflect the new API. However, there are a few places where the options.FindOptionsBuilder and options.FindOneOptionsBuilder are passed directly to methods that expect *options.FindOptions and *options.FindOneOptions respectively, which will lead to compilation errors. Additionally, a mongo.Connect call in the integration tests needs to be updated to match the new v2 signature. Please address these issues to ensure full compatibility with the new driver version.
8f80fd8 to
b0927d6
Compare
|
/gcbrun |
Description
Update mongo-driver to v2, as requested by @duwenxin99
🛠️ Fixes #2335