Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

chore: Cleanup old CI jobs - #385

Merged
lqiu96 merged 1 commit into
mainfrom
main-cleanup_ci_jobs
Nov 29, 2022
Merged

chore: Cleanup old CI jobs#385
lqiu96 merged 1 commit into
mainfrom
main-cleanup_ci_jobs

Conversation

@lqiu96

@lqiu96 lqiu96 commented Nov 29, 2022

Copy link
Copy Markdown
Member

This was part of the previous PR #376 (comment)

@lqiu96

lqiu96 commented Nov 29, 2022

Copy link
Copy Markdown
Member Author

Should we set the CLIRR check be required?

@lqiu96
lqiu96 requested a review from blakeli0 November 29, 2022 15:36
@lqiu96
lqiu96 marked this pull request as ready for review November 29, 2022 15:36
@lqiu96
lqiu96 requested a review from a team November 29, 2022 15:36
@blakeli0

Copy link
Copy Markdown
Contributor

Should we set the CLIRR check be required?

No, they should be optional. There are some classes with InternalApi which are OK to make breaking changes.

@lqiu96
lqiu96 merged commit fe1a7c5 into main Nov 29, 2022
@lqiu96
lqiu96 deleted the main-cleanup_ci_jobs branch November 29, 2022 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants