re2: fix null pointer dereference in Set::Compile() failure path#636
Open
rui-wang-8 wants to merge 1 commit into
Open
re2: fix null pointer dereference in Set::Compile() failure path#636rui-wang-8 wants to merge 1 commit into
rui-wang-8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Prog::CompileSet()returnsnullptr(e.g., DFA memoryexhaustion), the internal state of
Setbecomes inconsistent:compiled_is already set totruebutprog_isnullptr.A subsequent call to
Set::Match()passes the!compiled_checkand dereferences the null
prog_.Fix: set
compiled_based on whether compilation actually succeeded,rather than unconditionally before it. Similarly, defer
elem_.clear()so that state remains valid for retry on failure.
This restores the invariant:
compiled_impliesprog_ != nullptr.Also add a regression test using
max_mem(1)to guaranteecompilation failure.