fix(live): forward thinking config#5905
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
Collaborator
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! This PR looks great and has a clear explanation and associated issue. To help the reviewers merge your PR more efficiently, could you please provide the following information as per our contribution guidelines:
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerateContentConfig.thinking_configintoLiveConnectConfigbefore opening Gemini live sessionslive_connect_config.thinking_configuntouched when the request config has no thinking configGemini.connect()Fixes #5805.
To verify
$env:PYTHONPATH=(Resolve-Path src).Path; python -m pytest tests\unittests\models\test_google_llm.py -q$env:PYTHONPATH=(Resolve-Path src).Path; python -m py_compile src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.pypython -m pyink --check src\google\adk\models\google_llm.py tests\unittests\models\test_google_llm.pygit diff --checkNote: pylint on the full
google_llm.pymodule still reports pre-existing warnings unrelated to this change, so I did not treat that as a blocker.