Skip to content

chore: bump requests to >= 2.33.0 - #1737

Merged
no23reason merged 1 commit into
gooddata:masterfrom
no23reason:dho/triv-requests-cve
Aug 14, 2026
Merged

chore: bump requests to >= 2.33.0#1737
no23reason merged 1 commit into
gooddata:masterfrom
no23reason:dho/triv-requests-cve

Conversation

@no23reason

@no23reason no23reason commented Aug 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This version fixes CVE-2026-25645. Also loosen the version so that in the future users can update requests on their own.

risk: low

Summary by CodeRabbit

  • Chores
    • Updated the Requests library compatibility range to support newer 2.x releases.
    • Applied the same dependency update across the dbt and SDK packages.

@no23reason
chore: bump requests to >= 2.33.0
049bc4a 
This version fixes CVE-2026-25645. Also loosen the version
so that in the future users can update requests on their own.

risk: low
@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a70ff409-1134-4cf4-83a1-d285c2200c9d

📥 Commits

Reviewing files that changed from the base of the PR and between 942b1e9 and 049bc4a.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • packages/gooddata-dbt/pyproject.toml
  • packages/gooddata-sdk/pyproject.toml
📝 Walkthrough

Walkthrough

The pull request updates the requests dependency constraint in the GoodData dbt and SDK packages from ~=2.32.0 to >=2.33.0,<3.0.0.

Changes

Requests constraint update

Layer / File(s) Summary
Update package dependency constraints
packages/gooddata-dbt/pyproject.toml, packages/gooddata-sdk/pyproject.toml		 Both packages now require requests version 2.33.0 or newer and below 3.0.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 049bc

This PR makes a localized requests dependency update and does not introduce any actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: lupko, pcerny, hkad98

Poem

A rabbit checks the package gate,
“Two-thirty-three is now the date.”
Below three-oh, the path is clear,
I twitch my nose and hop with cheer.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the requests dependency requirement to version 2.33.0 or later.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.44%. Comparing base (942b1e9) to head (049bc4a).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1737   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files         272      272           
  Lines       19012    19012           
=======================================
  Hits        15105    15105           
  Misses       3907     3907

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@no23reason
no23reason merged commit 005700c into gooddata:master Aug 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkad98 hkad98 hkad98 approved these changes
@lupko lupko Awaiting requested review from lupko lupko is a code owner
@pcerny pcerny Awaiting requested review from pcerny pcerny is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@no23reason @hkad98