add a few macros and functions - #5
Closed
faretek1 wants to merge 0 commit into
Closed
Conversation
aspizu
requested changes
Mar 11, 2025
Author
|
i removed it then |
Author
|
bump |
aspizu
reviewed
Apr 7, 2025
| ASSERT_EQ(LOGB(8, 2), 3, "LOGB(8, 2)") | ||
| ASSERT_EQ(SIGN(123), 1, "SIGN(123)") | ||
| ASSERT_EQ(SIGN(0), 0, "SIGN(0)") | ||
| ASSERT_EQ(SIGN(-456), 1, "SIGN(-456)") |
Author
There was a problem hiding this comment.
last one should be. ill change it
Author
|
I now realise that making a pull request means that one should check through the code for obvious mistakes. i found another issue where the logb macro was tested, but it was previously removed, for example. i have checked through all the code. I think that I tested it at the time. However, due to floating point error, the test script might not be fully accurate. maybe a rounding to ~3dp would be ideal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr just adds a few macros/functions that i thought would be useful