Added Strata Language #7749
Added Strata Language #7749
Conversation
Add Strata language support with specific rules.
lildude
left a comment
There was a problem hiding this comment.
This PR is invalid. Please follow the instructions in the CONTRIBUTING.md file.
|
@lildude How is the PR invalid? I want some details. |
Alhadis
left a comment
There was a problem hiding this comment.
Removing fn let from the .srt extension search yields numerous ostensibly unrelated files that happen to use the same file extension. How many of these are Strata files, and how many are other/unrecognised formats?
The number of results averages around ~249 as of this writing, which likely only barely scratches the minimum usage criteria of 200+ user/repositories that use Strata, and that's with the possibly-irrelevant .srt results included.
lib/linguist/languages.yml
Outdated
| tm_scope: source.scilab | ||
| ace_mode: text | ||
| language_id: 344 | ||
| SCIL: |
There was a problem hiding this comment.
What is SCIL?
You'll need to include samples for SCIL as well; all languages added to Linguist require real-world examples of the format to train Linguist's classifier.
There was a problem hiding this comment.
So @Alhadis It was an old project made like 3 months ago.
| @@ -0,0 +1,46 @@ | |||
| { | |||
There was a problem hiding this comment.
You haven't added this grammar correctly. You need to use the script/add-grammar program to add the grammar's repository as a submodule (which requires that it exist as an external project).
$ ./script/add-grammar https://github.com/user/strata-grammar-repositoryCo-authored-by: John Gardner <gardnerjohng@gmail.com>
|
@Alhadis So I need some help, the "SCIL" language in the commits section is not there in my fork. In my left bar of Github (where home, feed etc. is there) there's also github-linguist/linguist. I didn't click the "make a fork" button since I had already a fork. Can you help me revert these changes and only focus on Strata. GitHub Codespaces isn't loading for me. And also, I'm on a Windows working environment and can't run Unix shell scripts. Any help would be helpful. (UPDATE: Removed SCIL language from languages.yml) |
Removed SCIL language entry from languages.yml
#4B0082