-
Notifications
You must be signed in to change notification settings - Fork 5k
Add Teal language support #7601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Teal language support #7601
Conversation
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comment.
We also explicitly state we want real world samples (contrived samples are not good ways to train the classifier) and will reject PRs with "Hello world" samples… your types.tl looks remarkable like a "Hello world" sample.
Please replace your samples with real samples and update the PR template to link to the original sources (not Linguist or your fork).
When you added the grammar, the script/add-grammar should have also generated a cached version of the grammar's license. This needs to be added to this PR too.
And finally…
Search results for each extension:
https://github.com/search?q=filename%3Atlconfig.lua+NOT+is%3Afork&type=code (359 repositories)
I'm not sure how you got the number when your search query is invalid. Correcting it to search for just that filename returns only 87 files which is a very very long way from meeting our usage requirements. I recommend you update your search to search for the .tl extension and use your heuristic (search accepts regex) to narrow the results down to just this language.
10dc2e3 to
3359ba4
Compare
I've updated the sample to show code from a two public Teal projects. The CONTRIBUTING.md file has some wording that made me think samples made just for the PR were ok, but I've removed them and used real world code.
Done
Sorry! Copy paste error. I've updated the search in the PR. I think this search in more representative, and show 2.8K files, though I don't know how to slice that into unique repositories. |
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Important
The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.
See https://teal-language.org
Description
This PR adds support for the Teal, a statically-typed dialect of Lua.
Checklist:
#00B1BC