Skip to content

Output for verify command #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btoews merged 1 commit into from
May 7, 2019
Merged

Output for verify command #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions command_verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"bytes"
"crypto/x509"
"encoding/pem"
"fmt"
"io"
"os"

Expand Down Expand Up @@ -63,17 +64,25 @@ func verifyAttached() error {
if len(chains) > 0 {
emitBadSig(chains)
} else {
// TODO: We're ommitting a bunch of arguments here.
// TODO: We're omitting a bunch of arguments here.
sErrSig.emit()
}

return errors.Wrap(err, "failed to verify signature")
}

var (
cert = chains[0][0][0]
fpr = certHexFingerprint(cert)
subj = cert.Subject.String()
)

fmt.Fprintf(stderr, "smimesign: Signature made using certificate ID 0x%s\n", fpr)
emitGoodSig(chains)

// TODO: Maybe split up signature checking and certificate checking so we can
// output something more meaningful.
fmt.Fprintf(stderr, "smimesign: Good signature from \"%s\"\n", subj)
emitTrustFully()

return nil
Expand Down Expand Up @@ -131,17 +140,25 @@ func verifyDetached() error {
if len(chains) > 0 {
emitBadSig(chains)
} else {
// TODO: We're ommitting a bunch of arguments here.
// TODO: We're omitting a bunch of arguments here.
sErrSig.emit()
}

return errors.Wrap(err, "failed to verify signature")
}

var (
cert = chains[0][0][0]
fpr = certHexFingerprint(cert)
subj = cert.Subject.String()
)

fmt.Fprintf(stderr, "smimesign: Signature made using certificate ID 0x%s\n", fpr)
emitGoodSig(chains)

// TODO: Maybe split up signature checking and certificate checking so we can
// output something more meaningful.
fmt.Fprintf(stderr, "smimesign: Good signature from \"%s\"\n", subj)
emitTrustFully()

return nil
Expand Down
4 changes: 2 additions & 2 deletions status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,15 +206,15 @@ func emitSigCreated(cert *x509.Certificate, isDetached bool) {

func emitGoodSig(chains [][][]*x509.Certificate) {
cert := chains[0][0][0]
subj := cert.Subject.ToRDNSequence().String()
subj := cert.Subject.String()
fpr := certHexFingerprint(cert)

sGoodSig.emitf("%s %s", fpr, subj)
}

func emitBadSig(chains [][][]*x509.Certificate) {
cert := chains[0][0][0]
subj := cert.Subject.ToRDNSequence().String
subj := cert.Subject.String
fpr := certHexFingerprint(cert)

sBadSig.emitf("%s %s", fpr, subj)
Expand Down