Correct file descriptors on Windows - #40
Merged
Merged
Conversation
|
Closes: #41 |
Contributor
Author
|
Continuing a conversation with @henning-schild from email: With regards to this PR relying on the magic numbers, I don't think there is a great alternative. On Unix systems, we can use |
|
If you can not access the values of syscall_unix from windows, you could leave a comment or give them names with something like that: |
Contributor
Author
|
👍 I like that idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported that signature verification with Git wasn't working on Windows. Git passes
--status-fd=1, which isn't the correct file descriptor for stdout on Windows. This RP works around this by special casing file descriptors 1 and 2 to mean stdout and stderr respectively.