Skip to content

Fix tokens in inspector logging #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timvaillancourt merged 2 commits into from
Dec 8, 2023
Merged

Fix tokens in inspector logging #1226

timvaillancourt merged 2 commits into from
Dec 8, 2023

Conversation

@timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Dec 10, 2022 •
edited
Loading

Description

This PR fixes broken logs in the inspector due to using this.migrationContext.Log.Warning(...) (with %+v tokens) instead of .Warningf(...)

Currently the log lines in question do not format correctly:

2022-12-10 02:48:09 WARNING Will not use %!v(MISSING) as shared key due to FLOAT data type [f_uidx]

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@timvaillancourt timvaillancourt requested review from a user and rashiq December 10, 2022 20:03
@timvaillancourt timvaillancourt added this to the v1.1.7 milestone Dec 7, 2023
@timvaillancourt timvaillancourt merged commit 347d8e0 into github:master Dec 8, 2023
@timvaillancourt timvaillancourt deleted the log-cleanup-v1 branch December 8, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meiji163 meiji163 meiji163 approved these changes

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

Assignees

No one assigned

Labels

bug low-risk

Projects

None yet

Milestone

v1.1.7

Development

Successfully merging this pull request may close these issues.

2 participants

@timvaillancourt @meiji163