Use switch statements for readability, simplify .NewGoMySQLReader()
#1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch statements for readabilityswitch statements for readability, simplify .NewGoMySQLReader()
ghost
approved these changes
Jul 6, 2022
ghost
pushed a commit
that referenced
this pull request
Jul 7, 2022
…)` (#1135) * Use `switch` statements for readability * Simplify initBinlogReader()
Closed
ghost
pushed a commit
that referenced
this pull request
Jul 7, 2022
…)` (#1135) * Use `switch` statements for readability * Simplify initBinlogReader()
RainbowDashy
pushed a commit
to RainbowDashy/gh-ost
that referenced
this pull request
Jul 11, 2022
…)` (github#1135) * Use `switch` statements for readability * Simplify initBinlogReader()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves 2 x blocks of code to use
switchstatements for a bit more clarity, as suggested by thegocriticlinter. Also the.NewGoMySQLReader()func ofgo/binlog/gomysql_reader.gowas simplified (unusederrremoved, etc)This change should result in the exact same behaviour as before
Details:
go/binlog/gomysql_reader.goerrreturnswitchfor binlog event type ingo/binlog/gomysql_reader.goswitchon theCutOverTypefield to pick cutover logicscript/cibuildreturns with no formatting errors, build errors or unit test errors