Deduplicate custom linter analyzer scaffolding by Copilot · Pull Request #50700 · github/gh-aw

Copilot · 2026-08-05T22:20:12Z

Custom linters repeated analyzer metadata, default dependencies, repository URLs, and inspector traversal setup across dozens of packages. This centralizes the shared wiring while preserving specialized traversal paths.

Shared analyzer utility
- Add internal/analyzerutil for standard analyzer construction.
- Centralize default inspect, nolint, and filecheck dependencies.
- Construct consistent source URLs, including explicit package-path support.
Shared traversal bootstrap
- Add a reusable preorder helper that retrieves the inspector and propagates setup errors.
- Migrate compatible linters to the helper; retain direct inspector access where cursor traversal is required.
Linter migration
- Replace 62 duplicated analyzer declarations with the shared factory.
- Preserve analyzer names, documentation, URLs, dependencies, and run behavior.

var Analyzer = analyzerutil.New(
    "appendbytestring",
    "reports redundant []byte string conversions in append calls",
    run,
)

return analyzerutil.Preorder(pass, nodeFilter, func(n ast.Node) {
    analyzeAppendByteString(pass, n, generatedFiles, noLintIndex)
})

Fixes [duplicate-code] Duplicate linter analyzer scaffolding across pkg/linters #50697

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.2 AIC · ⌖ 5.16 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 6.47 AIC · ⌖ 6.82 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Centralizes custom linter analyzer scaffolding to resolve #50697 while preserving specialized cursor-based traversal.

Changes:

Adds shared analyzer factories with standard dependencies and URLs.
Adds reusable preorder traversal setup.
Migrates 62 linters while retaining specialized traversal where required.

Show a summary per file

File	Description
`pkg/linters/appendbytestring/appendbytestring.go`	Uses shared factory and preorder helper.
`pkg/linters/appendoneelement/appendoneelement.go`	Uses shared factory and preorder helper.
`pkg/linters/bytesbufferstring/bytesbufferstring.go`	Uses shared factory and preorder helper.
`pkg/linters/bytescomparestring/bytescomparestring.go`	Uses shared factory and preorder helper.
`pkg/linters/contextcancelnotdeferred/contextcancelnotdeferred.go`	Uses shared factory and preorder helper.
`pkg/linters/ctxbackground/ctxbackground.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/deferinloop/deferinloop.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/errorfwrapv/errorfwrapv.go`	Uses shared factory and preorder helper.
`pkg/linters/errormessage/errormessage.go`	Uses shared factory and preorder helper.
`pkg/linters/errortypeassertion/errortypeassertion.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/errstringmatch/errstringmatch.go`	Uses shared factory and preorder helper.
`pkg/linters/excessivefuncparams/excessivefuncparams.go`	Uses shared factory and preorder helper.
`pkg/linters/execcommandwithoutcontext/execcommandwithoutcontext.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/fileclosenotdeferred/fileclosenotdeferred.go`	Uses shared factory and preorder helper.
`pkg/linters/fmterrorfnoverbs/fmterrorfnoverbs.go`	Uses shared factory and preorder helper.
`pkg/linters/fprintlnsprintf/fprintlnsprintf.go`	Uses shared factory and preorder helper.
`pkg/linters/goroutinemissingrecover/goroutinemissingrecover.go`	Uses shared factory and preorder helper.
`pkg/linters/hardcodedfilepath/hardcodedfilepath.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/httpnoctx/httpnoctx.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/httprespbodyclose/httprespbodyclose.go`	Uses shared factory and preorder helper.
`pkg/linters/httpstatuscode/httpstatuscode.go`	Uses shared factory; preserves specialized traversal.
`pkg/linters/internal/analyzerutil/analyzerutil.go`	Adds analyzer factories and preorder bootstrap.
`pkg/linters/internal/analyzerutil/analyzerutil_test.go`	Tests metadata, URLs, and dependencies.
`pkg/linters/ioutildeprecated/ioutildeprecated.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/jsonmarshalignoredeerror/jsonmarshalignoredeerror.go`	Uses shared factory and preorder helper.
`pkg/linters/largefunc/largefunc.go`	Uses shared factory and preorder helper.
`pkg/linters/lenstringsplit/lenstringsplit.go`	Uses shared factory and preorder helper.
`pkg/linters/lenstringzero/lenstringzero.go`	Uses shared factory and preorder helper.
`pkg/linters/logfatallibrary/logfatallibrary.go`	Uses shared factory and preorder helper.
`pkg/linters/manualmutexunlock/manualmutexunlock.go`	Uses shared factory and preorder helper.
`pkg/linters/mapclearloop/mapclearloop.go`	Uses shared factory and preorder helper.
`pkg/linters/mapdeletecheck/mapdeletecheck.go`	Uses shared factory and preorder helper.
`pkg/linters/nilctxpassed/nilctxpassed.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/osexitinlibrary/osexitinlibrary.go`	Uses shared factory and preorder helper.
`pkg/linters/osgetenvlibrary/osgetenvlibrary.go`	Uses shared factory and preorder helper.
`pkg/linters/ossetenvlibrary/ossetenvlibrary.go`	Uses shared factory and preorder helper.
`pkg/linters/panic-in-library-code/panic-in-library-code.go`	Uses path-aware factory and cursor traversal.
`pkg/linters/rawloginlib/rawloginlib.go`	Uses shared factory and preorder helper.
`pkg/linters/regexpcompileinfunction/regexpcompileinfunction.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/regexpdynamicpattern/regexpdynamicpattern.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/seenmapbool/seenmapbool.go`	Uses shared factory and preorder helper.
`pkg/linters/sortslice/sortslice.go`	Uses shared factory; preserves specialized traversal.
`pkg/linters/sprintfbool/sprintfbool.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/sprintferrdot/sprintferrdot.go`	Uses shared factory and preorder helper.
`pkg/linters/sprintferrorsnew/sprintferrorsnew.go`	Uses shared factory and preorder helper.
`pkg/linters/sprintfint/sprintfint.go`	Uses shared factory and preorder helper.
`pkg/linters/strconvparseignorederror/strconvparseignorederror.go`	Uses shared factory and preorder helper.
`pkg/linters/stringbytesroundtrip/stringbytesroundtrip.go`	Uses shared factory and preorder helper.
`pkg/linters/stringreplaceminusone/stringreplaceminusone.go`	Uses shared factory and preorder helper.
`pkg/linters/stringsconcatloop/stringsconcatloop.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/stringscountcontains/stringscountcontains.go`	Uses shared factory and preorder helper.
`pkg/linters/stringsindexcontains/stringsindexcontains.go`	Uses shared factory and preorder helper.
`pkg/linters/stringsindexhasprefix/stringsindexhasprefix.go`	Uses shared factory and preorder helper.
`pkg/linters/stringsjoinone/stringsjoinone.go`	Uses shared factory and preorder helper.
`pkg/linters/timeafterleak/timeafterleak.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/timenowsub/timenowsub.go`	Uses shared factory and preorder helper.
`pkg/linters/timesleepnocontext/timesleepnocontext.go`	Uses shared factory; preserves cursor traversal.
`pkg/linters/tolowerequalfold/tolowerequalfold.go`	Uses shared factory and preorder helper.
`pkg/linters/trimleftright/trimleftright.go`	Uses shared factory and preorder helper.
`pkg/linters/uncheckedflushreturn/uncheckedflushreturn.go`	Uses shared factory and preorder helper.
`pkg/linters/uncheckedtypeassertion/uncheckedtypeassertion.go`	Uses shared factory and preorder helper.
`pkg/linters/walkfuncerrshadow/walkfuncerrshadow.go`	Uses shared factory and preorder helper.
`pkg/linters/wgdonenotdeferred/wgdonenotdeferred.go`	Uses shared factory and preorder helper.
`pkg/linters/writebytestring/writebytestring.go`	Uses shared factory and preorder helper.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 64/64 changed files
Comments generated: 0
Review effort level: Balanced

…olding

gh-aw-bot · 2026-08-05T23:22:42Z

@copilot please review the latest PR feedback, refresh this branch if it is behind main, then run the pr-finisher skill and push any follow-up fixes.

failed checks:
- Unit tests (A-C): https://github.com/github/gh-aw/actions/runs/31053195109/job/92470567226

Run: https://github.com/github/gh-aw/actions/runs/31055742237

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.2 AIC · ⌖ 5.16 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

…olding

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-05T23:30:42Z

@copilot please review the latest PR feedback, refresh this branch if it is behind main, then run the pr-finisher skill and push any follow-up fixes.

failed checks:...

Fixed. The CI failure was caused by .github/aw/actions-lock.json having its containers field keys out of lexicographic order (ghcr.io/fabio-rovai/open-ontologies:latest was missing from the sorted position). Sorted the keys and the TestActionsLockJSONFieldsAreSorted test now passes.

…olding

gh-aw-bot · 2026-08-05T23:46:34Z

@copilot thanks for the follow-up. CI appears complete now. Please run the pr-finisher skill, address any remaining review feedback if needed, and push any final polish before maintainer review.

Run: https://github.com/github/gh-aw/actions/runs/31057198185

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 6.47 AIC · ⌖ 6.82 AIC · ⊞ 8.3K · ◷
_{Comment /souschef to run again}

Initial plan

1bc5cae

Copilot AI assigned Copilot and pelikhan Aug 5, 2026

Copilot started work on behalf of pelikhan August 5, 2026 22:20 View session

Copilot AI linked an issue Aug 5, 2026 that may be closed by this pull request

[duplicate-code] Duplicate linter analyzer scaffolding across pkg/linters #50697

Closed

7 tasks

Deduplicate linter analyzer scaffolding

5f95890

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor duplicate linter analyzer scaffolding in pkg/linters~~ Deduplicate custom linter analyzer scaffolding Aug 5, 2026

Copilot AI requested a review from pelikhan August 5, 2026 22:34

Copilot finished work on behalf of pelikhan August 5, 2026 22:34

pelikhan marked this pull request as ready for review August 5, 2026 23:00

Copilot AI balanced review requested due to automatic review settings August 5, 2026 23:00

Copilot started reviewing on behalf of pelikhan August 5, 2026 23:00 View session

Copilot AI reviewed Aug 5, 2026

View reviewed changes

Merge branch 'main' into copilot/duplicate-code-linter-analyzer-scaff…

ea35af3

…olding

github-actions Bot mentioned this pull request Aug 5, 2026

[pr-sous-chef] pr-sous-chef run report #50440

Closed

Copilot started work on behalf of gh-aw-bot August 5, 2026 23:23 View session

pelikhan and others added 2 commits August 5, 2026 16:24

Merge branch 'main' into copilot/duplicate-code-linter-analyzer-scaff…

b9ded69

…olding

Fix actions-lock.json containers field sort order

a05c53a

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 5, 2026 23:30

Copilot AI requested a review from gh-aw-bot August 5, 2026 23:30

pelikhan added 2 commits August 5, 2026 16:36

Merge branch 'main' into copilot/duplicate-code-linter-analyzer-scaff…

f080b2e

…olding

Merge branch 'main' into copilot/duplicate-code-linter-analyzer-scaff…

b9479e9

…olding

Copilot started work on behalf of gh-aw-bot August 5, 2026 23:47 View session

Copilot finished work on behalf of gh-aw-bot August 5, 2026 23:56

pelikhan merged commit 54c99ac into main Aug 6, 2026
31 checks passed

pelikhan deleted the copilot/duplicate-code-linter-analyzer-scaffolding branch August 6, 2026 00:17

github-actions Bot mentioned this pull request Aug 6, 2026

[pr-sous-chef] PR Sous Chef run report #50715

Open

Navigation Menu

Uh oh!

Deduplicate custom linter analyzer scaffolding - #50700

Deduplicate custom linter analyzer scaffolding#50700
pelikhan merged 7 commits into
mainfrom
copilot/duplicate-code-linter-analyzer-scaffolding

Copilot AI commented Aug 5, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

gh-aw-bot commented Aug 5, 2026

Uh oh!

Copilot AI commented Aug 5, 2026

Uh oh!

gh-aw-bot commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Aug 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

gh-aw-bot commented Aug 5, 2026

Uh oh!

Copilot AI commented Aug 5, 2026

Uh oh!

gh-aw-bot commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 5, 2026 •

edited by github-actions Bot

Loading