Fix build-wasm: update golden files for actions: read permission#25000
Merged
Fix build-wasm: update golden files for actions: read permission#25000
actions: read permission#25000Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7d59429c-c58e-4026-ba33-aa7932242bad Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 7, 2026 02:01
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates WASM golden workflow outputs to match a newly emitted actions: read permission on the activation job, fixing TestWasmGolden_CompileFixtures failures caused by golden drift.
Changes:
- Add
actions: readunderjobs.activation.permissionsin the WASM golden outputs. - Regenerate affected golden files via
make update-wasm-golden.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden | Updates activation job permissions to include actions: read to match current compiler output. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden | Same golden update: includes actions: read for activation job permissions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestWasmGolden_CompileFixtureswas failing because the compiler now emitsactions: readin the activation job's permissions block, but the golden files hadn't been updated to match.Changes
basic-copilot.goldenandwith-imports.goldento addactions: readto the activation job permissions, regenerated viamake update-wasm-golden