This repository was archived by the owner on Sep 18, 2023. It is now read-only.
relax extends-correct-class rule for imports - #53
Merged
Conversation
jfuchs
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
extends-correct-classrule with an imported class, it is not possible to determine the superclass from the import statement alone.Currently, we fail the check because the
classRefTrackerwill track the Import Specifier, which will not have asuperClassproperty (as its anIdentifiernot aClassDefinition). This means that the rule, when turned on, fails on imported classes.This PR changes this to guard against linting identifiers which come from an
ImportDefaultSpecifierorImportSpecifier. The guard returns early, so the check is skipped. This means that the rule, when turned on, will no longer fail on imported classes.