This repository was archived by the owner on Sep 18, 2023. It is now read-only.
allow defining custom elements in a try/catch - #51
Merged
Conversation
jfuchs
approved these changes
Dec 14, 2022
keithamus
force-pushed
the
allow-defining-custom-elements-in-a-try-catch
branch
from
January 3, 2023 11:32
f96aa25 to
8c61b98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relaxes the
no-unchecked-definerule to allow forcustomElements.definecalls that exist within atry/catchblock. We've found thetry/catchpattern to be helpful when defining elements within the context of a custom elements HMR plugin, that expects you to calldefine()on each load.See github/relative-time-element#209 and github/catalyst#197 for more.