This repository was archived by the owner on Sep 18, 2023. It is now read-only.
allow exporting of Event sublcasses alongside custom elements - #50
Merged
keithamus merged 1 commit intoJan 3, 2023
Merged
Conversation
jfuchs
approved these changes
Dec 14, 2022
keithamus
force-pushed
the
allow-exporting-of-event-sublcasses-alongside-custom-elements
branch
from
January 3, 2023 11:33
d908e8b to
afcdf55
Compare
keithamus
deleted the
allow-exporting-of-event-sublcasses-alongside-custom-elements
branch
January 3, 2023 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relaxes the
no-exports-with-elementrule to allow sub classes of events to also be exported alongside the class.It's quite common to localise
Eventsubclasses within the custom element, and they may share data with the custom element itself. Having this rule relaxed for just event classes still keeps the intent of the rule in place, but means custom element authors won't end up having to work around the rule for Events.