Unify the aria attribute for octicons with text - #35376
Merged
nguyenalex836 merged 2 commits intoNov 21, 2024
Merged
Conversation
Contributor
nguyenalex836
previously approved these changes
Nov 21, 2024
nguyenalex836
approved these changes
Nov 21, 2024
nguyenalex836
enabled auto-merge
November 21, 2024 17:13
Contributor
|
@akordowski Thanks so much for opening a PR with these fixes! I'll update the branch and get this merged once tests are passing 🍏 |
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
As discussed in #35326 this PR unifies the aria attribute for octicons with text, by replacing
aria-label="..."witharia-hidden="true".Closes: #35326
What's being changed (if available, include any code snippets, screenshots, or gifs):
Replace aria-label with aria-hidden for octoicons with precedent or subsequent text
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
datadirectory.For content changes, I have completed the self-review checklist.