This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Corrected OAuth scopes required. - #465
Merged
Merged
Conversation
I thought requiring a "user" OAuth scope for reading team membership was a bit odd, so I tried it with "read:org" and it worked, so correcting the documentation. "write:org" and "admin:org" are untested, but would make more sense than "user".
Contributor
There was a problem hiding this comment.
I'd omit the write:org and admin:org stuff and just mention that read:org is a better option than user. 👍
Contributor
Author
|
@atmos: That better? Sorry for the extra grammar edit, should I squash it? (I was using the web interface.) |
Contributor
|
Yup, thanks @WrinklyNinja |
atmos
added a commit
that referenced
this pull request
Mar 26, 2014
Corrected OAuth scopes required.
hubot
added a commit
that referenced
this pull request
May 14, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought requiring a "user" OAuth scope for reading team membership was a bit odd, so I tried it with "read:org" and it worked, so correcting the documentation. "write:org" and "admin:org" are untested, but would make more sense than "user".