I assert this is necessary to enable the Java tests to run. - #2340
Open
edburns wants to merge 2 commits into
Open
I assert this is necessary to enable the Java tests to run.#2340edburns wants to merge 2 commits into
edburns wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edburns
requested review from
MackinnonBuck
and
a balanced review from Copilot
August 14, 2026 23:44
Contributor
There was a problem hiding this comment.
Pull request overview
Removes registry URLs from npm lockfiles so Java test setup respects configured registries.
Changes:
- Omits registry resolution metadata from two lockfiles.
- Updates dependency automation to preserve that format.
- Simplifies Java’s npm invocations.
Show a summary per file
| File | Description |
|---|---|
test/harness/package-lock.json |
Removes resolved registry URLs. |
nodejs/package-lock.json |
Removes resolved registry URLs. |
java/sdk/pom.xml |
Removes redundant npm flags. |
.github/workflows/update-copilot-dependency.yml |
Preserves omission during manual updates. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Files not reviewed (1)
- test/harness/package-lock.json: Generated file
- Files reviewed: 2/4 changed files
- Comments generated: 1
- Review effort level: Balanced
| VERSION: ${{ inputs.version }} | ||
| working-directory: ./nodejs | ||
| run: npm install "@github/copilot@$VERSION" | ||
| run: npm install "@github/copilot@$VERSION" --omit-lockfile-registry-resolved=true |
MackinnonBuck
approved these changes
Aug 14, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f787ed29-2541-42ff-85da-d3baef89d667
Contributor
Cross-SDK Consistency Review ✅This PR makes only build/infrastructure changes:
There are no SDK API surface changes in this PR. No cross-language consistency issues to flag.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to avoid becoming an expert on the npm authentication infrastructure.