Skip to content

Fix codegen for internal runtime schemas - #2331

Merged
stephentoub merged 1 commit into
mainfrom
stephentoub-fix-runtime-import
Aug 13, 2026
Merged

Fix codegen for internal runtime schemas#2331
stephentoub merged 1 commit into
mainfrom
stephentoub-fix-runtime-import

Conversation

@stephentoub

Copy link
Copy Markdown
Collaborator

@github/copilot 1.0.80-0 adds internal-only MCP schema shapes that caused the dependency update workflow to fail. TypeScript exposed an internal union variant through a public type, and C# attempted to map an in-process-only value that cannot cross the JSON-RPC boundary.

Changes

  • Filter internal anyOf and oneOf variants from public TypeScript unions while retaining internal definitions for internal APIs.
  • Omit internal x-opaque-in-process properties from C# output as unrepresentable SDK transport fields.

Validation

  • Generated all language SDK outputs against the 1.0.80-0 runtime schemas.
  • Regenerated against the pinned 1.0.79 schemas with no generated-file changes.

Generated by Copilot

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f0193925-3c4a-4142-b5c0-4ea48168a24b
Copilot AI balanced review requested due to automatic review settings August 13, 2026 20:55
@stephentoub
stephentoub requested a review from a team as a code owner August 13, 2026 20:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates schema code generation for internal runtime-only shapes.

Changes:

  • Filters internal variants from public TypeScript unions.
  • Omits unrepresentable in-process-only properties from C# output.
Show a summary per file
File Description
scripts/codegen/typescript.ts Filters internal anyOf/oneOf variants.
scripts/codegen/csharp.ts Omits internal opaque in-process properties.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread scripts/codegen/csharp.ts
Comment thread scripts/codegen/typescript.ts
@stephentoub
stephentoub merged commit f0c89d1 into main Aug 13, 2026
26 checks passed
@stephentoub
stephentoub deleted the stephentoub-fix-runtime-import branch August 13, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants