Skip untyped internal properties in C# codegen - #2298
Merged
Conversation
Remove internal properties without a representable schema shape before C# RPC generation, while preserving typed internal properties and strict failures for public schemas. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 510b87fe-e424-4389-a811-2a4c3a2181ff
Contributor
There was a problem hiding this comment.
Pull request overview
Adds C# schema preprocessing so code generation tolerates untyped internal-only RPC properties without weakening public-schema validation.
Changes:
- Clones RPC schemas before preprocessing.
- Recursively removes untyped internal properties.
Show a summary per file
| File | Description |
|---|---|
scripts/codegen/csharp.ts |
Adds internal-property filtering before RPC generation. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@github/copilot1.0.79-9 adds internal, in-process-only properties without JSON Schema types. The C# generator currently attempts to map every property to a C# type, causing dependency-update codegen to fail.Clone and preprocess the RPC schema before generation, recursively omitting only internal properties that have no representable schema shape. Typed internal properties continue to be generated, and untyped public properties still fail validation.
Validated generation against the exact 1.0.79-9 API and session-event schemas. Other language generators remain unchanged because they already tolerate these shapes.
Generated by Copilot