Skip to content

Conversation

@vivganes
Copy link

Root cause : test_session.py uses a prompt that is not there in the harness. It misses a string "note this", compared to other language SDKs.

@vivganes vivganes requested a review from a team as a code owner January 27, 2026 14:29
Copilot AI review requested due to automatic review settings January 27, 2026 14:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #227 where premium requests were being consumed during Python dev tests due to a prompt mismatch between the Python SDK test and the test harness used by other language SDKs.

Changes:

  • Updated the prompt string in test_session.py to include "(note this" to match the exact wording used in other language SDK tests (Node.js, Go, and .NET)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@friggeri friggeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails in CI because the code isn't formatted, can you please format it? Thanks!

@vivganes
Copy link
Author

@friggeri Done!

@vivganes vivganes requested a review from friggeri January 27, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants