Edburns/ghcp sp 122 java release improvements#1514
Merged
Conversation
modified: .github/aw/actions-lock.json modified: .github/workflows/java.notes.template modified: .github/workflows/release-changelog.lock.yml modified: .github/workflows/release-changelog.md Try to fix the 📦 [View on Maven Central]((central.sonatype.com/redacted) problem.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the preflight job in the Java Maven publish workflow so it validates the two release-specific secrets actually used downstream (JAVA_RELEASE_TOKEN for git/Maven pushes and JAVA_RELEASE_GITHUB_TOKEN for triggering the changelog workflow) instead of the default GITHUB_TOKEN. This makes preflight failures more accurately reflect what will go wrong later in the release.
Changes:
- Replace the
GITHUB_TOKENpush-permission check with one that verifiesJAVA_RELEASE_TOKENpush permission, with comments documenting all the steps that depend on it. - Replace the
gh api usercheck forJAVA_RELEASE_GITHUB_TOKENwith one that calls the repo actions/workflows API, reflecting its use forgh workflow run. - Refresh log/error messages to name the correct secret and described capability.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/java-publish-maven.yml | Rewrite preflight checks to validate JAVA_RELEASE_TOKEN push access and JAVA_RELEASE_GITHUB_TOKEN actions API access. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.