Skip to content

Accept OIDC configurations in start-proxy #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 16 commits into from
Mar 13, 2026
Merged

Accept OIDC configurations in start-proxy #3563

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
65f7f36
Extend `isPrintable` check to all keys with string values
mbg Mar 9, 2026
01b5262
Move out auth config from `Credential` type
mbg Mar 9, 2026
9e26f9e
Add OIDC config types
mbg Mar 9, 2026
37eb89b
Add predicates for `Auth` types
mbg Mar 10, 2026
7263be2
Extract `AuthConfig` from `Credential`
mbg Mar 10, 2026
e168f8e
Move `credentialToStr` and update it
mbg Mar 10, 2026
3d57420
Run more `start-proxy` tests in parallel
mbg Mar 10, 2026
4649e15
Fix old test
mbg Mar 10, 2026
88bd340
Add OIDC tests for `getCredentials`
mbg Mar 10, 2026
e90d128
Add preliminary change note
mbg Mar 10, 2026
131392e
Fix changelog entry
mbg Mar 10, 2026
823869d
Use `isDefined` for password and token in `credentialToStr`
mbg Mar 10, 2026
c6e75ac
Add JSON helper types and functions
mbg Mar 10, 2026
c92efdb
Type result of parsing JSON as `unknown` until narrowed
mbg Mar 10, 2026
048d0ea
Address review comments
mbg Mar 10, 2026
6c99ca5
Merge remote-tracking branch 'origin/main' into mbg/private-registry/…
mbg Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Extend isPrintable check to all keys with string values
  • Loading branch information
@mbg
mbg committed Mar 9, 2026
commit 65f7f363021bd8835a60edb52bc57ae3834241ee
11 changes: 7 additions & 4 deletions lib/start-proxy-action.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 8 additions & 11 deletions src/start-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,17 +354,14 @@ export function getCredentials(
return str ? /^[\x20-\x7E]*$/.test(str) : true;
};

if (
!isPrintable(e.type) ||
!isPrintable(e.host) ||
!isPrintable(e.url) ||
!isPrintable(e.username) ||
!isPrintable(e.password) ||
!isPrintable(e.token)
) {
throw new ConfigurationError(
"Invalid credentials - fields must contain only printable characters",
);
// Ensure that all string fields only contain printable characters.
for (const key of Object.keys(e)) {
const val = e[key];
if (typeof val === "string" && !isPrintable(val)) {
throw new ConfigurationError(
"Invalid credentials - fields must contain only printable characters",
);
}
}

// If the password or token looks like a GitHub PAT, warn if no username is configured.
Expand Down