Skip to content

Flag up functionality that may not exist in default setup workflows - #1678

Merged
henrymercer merged 9 commits into
mainfrom
henrymercer/default-setup-safeguarding
May 31, 2023
Merged

Flag up functionality that may not exist in default setup workflows#1678
henrymercer merged 9 commits into
mainfrom
henrymercer/default-setup-safeguarding

Conversation

@henrymercer

@henrymercer henrymercer commented May 12, 2023

Copy link
Copy Markdown
Contributor

This PR adds two internal CodeQL queries to identify environment variables and Actions context variables that may not work with default setup.

While we're here, we switch libraryPathDependencies to dependencies and modify the "Inconsistent Action inputs" query to ignore internal Actions.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Comment thread queries/codeql-pack.yml
@henrymercer henrymercer changed the title Add CodeQL queries to safeguard against using functionality that may not exist in default setup workflows Flag up functionality that may not exist in default setup workflows May 30, 2023
@henrymercer
henrymercer marked this pull request as ready for review May 30, 2023 21:06
@henrymercer
henrymercer requested a review from a team as a code owner May 30, 2023 21:06

@aeisenberg aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think I understand the QL.

Comment thread queries/default-setup-event-context.ql Outdated
Comment thread queries/default-setup-event-context.ql Outdated
@henrymercer
henrymercer requested a review from aeisenberg May 31, 2023 13:25

@aeisenberg aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce.

@henrymercer
henrymercer merged commit 89c4c9e into main May 31, 2023
@henrymercer
henrymercer deleted the henrymercer/default-setup-safeguarding branch May 31, 2023 16:33
@github-actions github-actions Bot mentioned this pull request Jun 1, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants