Python: Add support for bottle framework. - #872
Merged
Conversation
markshannon
force-pushed
the
python-bottle
branch
from
February 6, 2019 15:32
c305fb6 to
db96f6d
Compare
taus-semmle
suggested changes
Feb 11, 2019
taus-semmle
left a comment
Contributor
There was a problem hiding this comment.
A few comments/changes but otherwise LGTM. Regarding the test failures, there seems to be some confusion when qltest tries to create relative paths. I wonder if we have an ill-placed queries.xml file. (Also, I'm somewhat surprised that it doesn't complain about "locations outside the test directory".)
| import semmle.python.web.Http | ||
| import semmle.python.types.Extensions | ||
|
|
||
| /** The flask module */ |
| result = ModuleObject::named("bottle") | ||
| } | ||
|
|
||
| /** The flask app class */ |
| } | ||
|
|
||
| private Object theBottleResponseObject() { | ||
| result = theBottleModule().getAttribute("request") |
Contributor
There was a problem hiding this comment.
This should presumably be response.
| import semmle.python.web.bottle.General | ||
|
|
||
|
|
||
| /** A django.http.response.Response object |
markshannon
force-pushed
the
python-bottle
branch
from
February 11, 2019 16:34
db96f6d to
4f2c4b8
Compare
markshannon
force-pushed
the
python-bottle
branch
from
February 12, 2019 14:26
4f2c4b8 to
b644891
Compare
taus-semmle
approved these changes
Feb 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.